Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#112 followup (bugfix and fix build) #114

Merged
merged 5 commits into from
Dec 13, 2021
Merged

#112 followup (bugfix and fix build) #114

merged 5 commits into from
Dec 13, 2021

Conversation

Lurk
Copy link
Contributor

@Lurk Lurk commented Dec 7, 2021

This is #112 follow-up with two changes:

  1. We missed this part: "It is not possible to block SIGKILL or SIGSTOP. Attempts to do so are silently ignored." (https://man7.org/linux/man-pages/man2/sigprocmask.2.html) addressing that
  2. Fixing Clippy issue:
error: redundant pattern matching, consider using `is_err()`
  --> kernel/syscalls/rt_sigprocmask.rs:27:16
   |
27 |         if let Err(_) = current_process().set_signal_mask(how, set, oldset, length) {
   |         -------^^^^^^-------------------------------------------------------------- help: try this: `if current_process().set_signal_mask(how, set, oldset, length).is_err()`
   |
   = note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`

which we introduced in #112

kernel/process/process.rs Outdated Show resolved Hide resolved
kernel/process/process.rs Outdated Show resolved Hide resolved
@nuta
Copy link
Owner

nuta commented Dec 13, 2021

Looks good. Thanks!

@nuta nuta merged commit 1f9c2b4 into nuta:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants