Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uglifyjs-webpack-plugin from 1.1.8 to 1.2.0 in /www #842

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 18, 2018

Bumps uglifyjs-webpack-plugin from 1.1.8 to 1.2.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

@mods-bot
Copy link

mods-bot commented Feb 18, 2018

Deploy preview for nusmods ready!

Built with commit ecf751e

https://deploy-preview-842--nusmods.netlify.com

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/www/uglifyjs-webpack-plugin-1.2.0 branch from 3c4dd2d to e84c79a Compare February 18, 2018 07:19
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/www/uglifyjs-webpack-plugin-1.2.0 branch from e84c79a to 165ad85 Compare February 18, 2018 07:31
@taneliang
Copy link
Member

A new safari10 option was added, which is passed directly to UglifyJS2 and used as shorthand to set the safari10 option on both mangle and output.

As we support Safari 10, I've added that to our options, and removed the flag on mangle.

@taneliang taneliang requested a review from a team February 18, 2018 07:51
Copy link
Member

@ZhangYiJiang ZhangYiJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just do a quick test using Safari 10 to see if this broke anything? Otherwise 👍

@taneliang
Copy link
Member

I just poked it in Browserstack and everything seems good :)

@taneliang taneliang merged commit 5b4ce31 into master Feb 19, 2018
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/www/uglifyjs-webpack-plugin-1.2.0 branch February 19, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants