fix format date based on users locale #11908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
Fixes #10838, where before the
date
would be formatted incorrectly, and was not pickingLC_TIME
for time formatting, but it picked the first locale returned by thesys-locale
crate instead. Now it will format time based onLC_TIME
. For example,Note that I also changed the
default_env.nu
as otherwise the Time will show AM/PM twice. Also reason for thechrono
update is because this relies on a fix to upstream repo, which i initially submitted an issueUser-Facing Changes
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --check
to check standard code formatting (cargo fmt --all
applies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used
to check that you're using the standard code stylecargo test --workspace
to check that all tests pass (on Windows make sure to enable developer mode)cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"
to run the tests for the standard libraryAfter Submitting