-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new nunit.extensibility and nunit.extensibility.api assemblies #1612
base: version4
Are you sure you want to change the base?
Conversation
@manfred-brands As I told you on slack, I'm hoping you'll continue to review these major structural changes I'm making. This is another wide-ranging one and I think it will take some time, but the reviews are really productive. If you're worn out for the moment, I'll ask for volunteers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, except for two big issues:
- Don't drop nullability. Not even for NUnit tests. The NUnit.Analyzer will fix most errors.
- Come up with a better exception than
Exception
to throw.
src/Extensibility/nunit.extensibility.tests/nunit.extensibility.tests.csproj
Show resolved
Hide resolved
src/Extensibility/nunit.extensibility.tests/ExtensionSelectorTests.cs
Outdated
Show resolved
Hide resolved
src/Extensibility/nunit.extensibility.tests/ExtensionAssemblyTests.cs
Outdated
Show resolved
Hide resolved
Thanks for reviewing. To your general comments...
|
Why should unit test have a lower standard than the rest of the code? |
Sorry, but I don't think that not using nullability means "lower standard". We made an effort to keep high standards before it existed. It could mean that maintaining a higher standard becomes easier, which is why I'm working at it now. When it first came out, I didn't believe the hype and since then I've been mostly working alone. You convinced me to try it, to learn about it. That means you'll see me trying to find out if it's good in various places or not. Be happy for me. :-) NUnit.Analyzers: I didn't know it did that. That's probably why adding the Nullability.props import without adding the analyzer caused so much trouble. I think this stuff needs to be more centralized, perhaps in Directory.Build.props. |
Fixes #1049