Create new nunit.common assembly #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharliePoole
requested review from
a team and
veleek
and removed request for
a team
CharliePoole
changed the title
|
Getting this reviewed and merged will enable a number of things. I'm pretty sure we will find other things to move here as we go along, but I see that as being a file or two at a time, as demanded by other issues. |
src/NUnitEngine/nunit.engine.core.tests/nunit.engine.core.tests.csproj
Outdated
Show resolved
Hide resolved
CharliePoole
changed the title
|
I'll need to fix the conflicts and I want to check the defunct issue-1578 branch, which also created NUnit.Common to see if there is anything else to be added. Marked as WIP, briefly I hope. |
CharliePoole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1608
Throwing this out for review. I added only the InternalTrace code plus some classes that were using cross-project source links and so obviously belong in a common assembly.
I eliminated the NUnit.Common namespace and put all these things in NUnit, so they can be used without adding a using statement.
I also removed ILogging and ILogger interfaces, which didn't seem to be doing much for us.
I haven't moved the tests to a separate assembly yet but I think I should.