Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option 'path-type' #14

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Add option 'path-type' #14

merged 4 commits into from
Nov 27, 2019

Conversation

eine
Copy link
Contributor

@eine eine commented Nov 27, 2019

Fix #13

In this PR, two procedures to override the default value of MSYS2_PATH_TYPE are provided. On the one hand, if users set the environment variable, it is not overwritten. On the other hand, option pathType can be used to set the default. Supported values are strict, inherit, or any other (minimal).

Two tests are added to the workflow, one for each procedure.

BTW, @actions/core is updated.

@Ecco
Copy link
Contributor

Ecco commented Nov 27, 2019

Great, thanks! I think the syntax in the YAML file should rather be file-type instead of fileType. Just like runs-on is not runsOn.

@eine eine changed the title Add option pathType Add option 'path-type' Nov 27, 2019
@eine
Copy link
Contributor Author

eine commented Nov 27, 2019

Great, thanks! I think the syntax in the YAML file should rather be file-type instead of fileType. Just like runs-on is not runsOn.

Done!

@Ecco
Copy link
Contributor

Ecco commented Nov 27, 2019

Great, thanks!

@Ecco Ecco merged commit a59619f into numworks:master Nov 27, 2019
@eine eine deleted the opt-pathType branch November 27, 2019 10:11
@eine
Copy link
Contributor Author

eine commented Nov 27, 2019

@Ecco, would you mind updating v1, and optionally releasing a semver tag (https://github.com/actions/toolkit/blob/master/docs/action-versioning.md#versioning), so that this feature and update are available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine with golang action
2 participants