Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sphinx>3 #385

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Require sphinx>3 #385

merged 1 commit into from
Apr 25, 2022

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Apr 25, 2022

Sphinx 3.0 was released in Apr 5, 2020. Our next scheduled release is for September 2022. Sphinx 3 was the first release to officially support Python 3.7 (the minimum version of Python we officially support).

We currently don't even test with sphinx 3.

I would prefer bumping to sphinx>4.0.2, but I wanted to see what people thought about this first.

@rossbar
Copy link
Contributor

rossbar commented Apr 25, 2022

I'm 👍 for dropping support for old sphinx versions. In fact, I'd advocate for dropping all unsupported sphinx versions including 3.X, i.e. make the minimum version sphinx 4. Sphinx itself has already stated that they won't backport any patches to <4, and the recent breakage due to code removal from Jinja2 is a strong motivator to update for any project that is still relying on sphinx<4.

I would advocate for something like:

@larsoner
Copy link
Collaborator

I would prefer bumping to sphinx>4.0.2, but I wanted to see what people thought about this first.

4.0.0 is less just under a year old (released may 9, 2021). Requiring 4.0 seems like a quick turnaround, but given that the Sphinx folks aren't supporting it, I can live with it.

I would advocate for something like:

I like this plan to push out a 1.3 ASAP then in >= 1.4 require 4.0. @jarrodmillman would you be up for making another release for 1.3?

@larsoner larsoner merged commit eb22997 into numpy:main Apr 25, 2022
@larsoner
Copy link
Collaborator

Thanks @jarrodmillman !

@jarrodmillman jarrodmillman mentioned this pull request Jun 8, 2022
@jarrodmillman jarrodmillman deleted the update-min-sphinx branch September 28, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants