-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence and visualizer switcher [cleaned] #379
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
18d24fc
feat: Sequence and Visualizer switchers, first pass at cleaned
gwhitney f6daa08
fix: Always show the current background and stroke colors in Turtle
gwhitney 117425f
fix: Don't refresh empty default parameters
gwhitney 544cac9
ui: move sequence search bar to right of Sequence Switcher popup title
gwhitney 33782aa
feat: Switchers now show thumbnails of the modified visualizers
gwhitney 6e7e31f
fix: Equalize space between sections of Gallery
gwhitney 520687b
feat: Resize Switcher modal popups to fit specimen cards cleanly
gwhitney f0af29c
feat: Placeholders for optional parameters
gwhitney c2374ca
fix: Make placeholders lighter
gwhitney bb79d07
ui: Pause visualizer while Switcher dialogues are open
gwhitney 2cd7f89
ui: Position Switcher popup centered over visualizer canvas
gwhitney c427155
fix: Restore Delft-submitted click behavior for closing Switcher
gwhitney 4b19af1
ui: Invoke Switchers via current seq/vis looking and acting like entr…
gwhitney 6155b81
fix: MageExchangeA icon should use current CSS color
gwhitney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
/* These variables will be included in every style section in the | ||
entire project | ||
*/ | ||
|
||
$tablet-breakpoint: 800px; | ||
$mobile-breakpoint: 580px; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
<template> | ||
<svg | ||
width="24" | ||
height="24" | ||
viewBox="0 0 24 24" | ||
fill="none" | ||
xmlns="http://www.w3.org/2000/svg"> | ||
<path | ||
d="M3.52942 11.4706V13.5882C3.52942 14.7115 3.97564 15.7888 4.76991 16.583C5.56418 17.3773 6.64144 17.8235 7.76471 17.8235H20.4706" | ||
stroke="currentColor" | ||
stroke-width="1.5" | ||
stroke-linecap="round" | ||
stroke-linejoin="round" /> | ||
<path | ||
d="M3.52942 6.17647H16.2353C17.3586 6.17647 18.4358 6.62268 19.2301 7.41696C20.0244 8.21123 20.4706 9.28849 20.4706 10.4118V12.5294" | ||
stroke="currentColor" | ||
stroke-width="1.5" | ||
stroke-linecap="round" | ||
stroke-linejoin="round" /> | ||
<path | ||
d="M17.2941 14.6471L20.4706 17.8235L17.2941 21" | ||
stroke="currentColor" | ||
stroke-width="1.5" | ||
stroke-linecap="round" | ||
stroke-linejoin="round" /> | ||
<path | ||
d="M6.70589 9.35294L3.52942 6.17647L6.70589 3" | ||
stroke="currentColor" | ||
stroke-width="1.5" | ||
stroke-linecap="round" | ||
stroke-linejoin="round" /> | ||
</svg> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import {defineComponent} from 'vue' | ||
|
||
/* https://mageicons.com/ | ||
Icon mage:exchange-a | ||
Used according to Apache Commons license; no attribution required. | ||
Note that stroke colors have been changed to currentColor, to allow | ||
ambient CSS color to be used. | ||
*/ | ||
export default defineComponent({ | ||
name: 'MageExchangeA', | ||
}) | ||
</script> | ||
|
||
<style></style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm attaching a screenshot. It doesn't seem like the use of mobile phone real estate is optimized yet. At least in this screenshot, there's clearly room to wrap the text but it isn't, it runs off the right, as does the picture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, ugh, yes, it does seem like this needs to be addressed before merging this PR. Not really my forte, so if anyone else wants to jump in I would welcome it, but if this PR ends up stuck on just this I will give it a shot.