Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery page #341

Merged
merged 14 commits into from
Jun 2, 2024
Merged

Gallery page #341

merged 14 commits into from
Jun 2, 2024

Conversation

mbavec
Copy link

@mbavec mbavec commented May 27, 2024

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the [contributing guidelines] (https://numberscope.colorado.edu/doc/CONTRIBUTING/) and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.


This adds the CSS for the gallery screen and added basic css variables to the app.vue file. Some of the relevant code was also refactored to make names more descriptive and compatible with future developments. Additionally, added an icon font and removed bootstrap.

@gwhitney
Copy link
Collaborator

As per plan, we want to merge into branch ui2 for now. Please adjust this PR to have destination ui2, or close it and reopen one into branch ui2. Thanks. Note that #338 has been merged into ui2, so you will want to rebase this on the latest ui2.

@gwhitney gwhitney marked this pull request as draft May 28, 2024 02:14
@mbavec mbavec changed the base branch from main to ui2 May 28, 2024 14:05
@mbavec
Copy link
Author

mbavec commented May 28, 2024

The branch has been adjusted to be compatible with ui2. It is now directed to merge with ui2 instead of main. Apologies for the oversight.

@mbavec mbavec marked this pull request as ready for review May 28, 2024 14:22
Copy link
Collaborator

@gwhitney gwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's all the review I could do from the code alone. It won't run for me at the moment (see the comments about "sass"). Once these are taken care of and it's running, I (and/or other members of the Numberscope team) can complete the review. Thanks!

src/App.vue Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/components/SpecimenCard.vue Show resolved Hide resolved
src/components/SpecimenCard.vue Outdated Show resolved Hide resolved
src/views/Gallery.vue Show resolved Hide resolved
src/views/Gallery.vue Show resolved Hide resolved
src/views/Gallery.vue Show resolved Hide resolved
src/views/Gallery.vue Show resolved Hide resolved
src/views/Gallery.vue Outdated Show resolved Hide resolved
@gwhitney
Copy link
Collaborator

Almost ready to finalize the review, just one remaining conversation about the "Change Visualizer" button. Also, just for your information and the rest of your team, we use the convention that only the initiator of a conversation should mark it as resolved (not the respondent) -- not sure if there is a way for us to enforce that in the GitHub user interface. So just as a courtesy, please let us the PR reviewers judge whether a conversation is resolved. Thanks!

@mbavec
Copy link
Author

mbavec commented May 31, 2024

Almost ready to finalize the review, just one remaining conversation about the "Change Visualizer" button. Also, just for your information and the rest of your team, we use the convention that only the initiator of a conversation should mark it as resolved (not the respondent) -- not sure if there is a way for us to enforce that in the GitHub user interface. So just as a courtesy, please let us the PR reviewers judge whether a conversation is resolved. Thanks!

My apologies I didn't know about this convention. I'll leave things unresolved from now on.

@gwhitney
Copy link
Collaborator

OK, this branch now passes typecheck and runs and the dev server is responsive. I observed the following "unfinished" or "in progress" aspects to the state of the frontscope UI as of this PR. Please just confirm that you are comfortable making a commit with these aspects, and I will go ahead and merge when I have your confirmation:

  1. The headers and footers appear, but they have no styling beyond browser-default styling.
  2. There is no link or button to access the gallery view anywhere in the UI so far as I can find; the only way to access it is to manually type the /gallery endpoint in the URL bar of the browser.
  3. There is no mechanism to get preview images into a SpecimenCard.
  4. There is an upward pointing caret at the top right of each section (for a specific visualizer) on the Gallery page that has no explanation and does not respond in any way to a click. I imagine it will be used to collapse the section but it currently has no functionality.

If you are OK with making a commit in this state, we will go ahead and do so. Thanks for confirming.

@mbavec
Copy link
Author

mbavec commented Jun 2, 2024

OK, this branch now passes typecheck and runs and the dev server is responsive. I observed the following "unfinished" or "in progress" aspects to the state of the frontscope UI as of this PR. Please just confirm that you are comfortable making a commit with these aspects, and I will go ahead and merge when I have your confirmation:

  1. The headers and footers appear, but they have no styling beyond browser-default styling.
  2. There is no link or button to access the gallery view anywhere in the UI so far as I can find; the only way to access it is to manually type the /gallery endpoint in the URL bar of the browser.
  3. There is no mechanism to get preview images into a SpecimenCard.
  4. There is an upward pointing caret at the top right of each section (for a specific visualizer) on the Gallery page that has no explanation and does not respond in any way to a click. I imagine it will be used to collapse the section but it currently has no functionality.

If you are OK with making a commit in this state, we will go ahead and do so. Thanks for confirming.

We were aware of these shortcomings and after having discussed it with the team we are comfortable with making a commit in this state. All of these issues and other features will be addressed in future commits.

Copy link
Collaborator

@gwhitney gwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been addressed. Ready to merge.

@gwhitney gwhitney merged commit 1cb5b80 into numberscope:ui2 Jun 2, 2024
2 checks passed
@maxd0328 maxd0328 deleted the gallery_page branch June 26, 2024 13:19
gwhitney pushed a commit that referenced this pull request Jan 20, 2025
Adds a route that shows a panel of thumbnails of multiple different specimens. This can be used, for example, for a curated list of interesting visualizers, or for an individual user's own visualizers.
---------
Co-authored-by: Max Derbenwick <[email protected]>
Co-authored-by: maxd0328 <[email protected]>
Co-authored-by: Kaldis Berzins <[email protected]>
Co-authored-by: mbavec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants