Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui2] Browser "back" not working (at least not reliably) #414

Closed
gwhitney opened this issue Aug 23, 2024 · 2 comments
Closed

[ui2] Browser "back" not working (at least not reliably) #414

gwhitney opened this issue Aug 23, 2024 · 2 comments
Assignees
@gwhitney
Labels
bug Something isn't working ui Something having to do with the user interface
Milestone
Alpha v0.5: ui2 ...

Comments

@gwhitney
Copy link
Collaborator

To reproduce, at least from the current contents of #406:

  1. Open the Tau Many Primes gallery visualization, e.g., http://localhost:5173/?name=Tau+Many+Primes&viz=FactorFence&signs=false&seq=OEIS+A000594
  2. Hit change sequence and select A000045, V-F numbers
  3. Use the browser's back button.

What I am observing is that the URL in the browser's URL bar changes back to the one shown above, but the visualization does not return to showing the Ramanujan tau numbers. Hitting the browser reload returns to that visualization. But it should not be necessary to hit reload, the visualization should update automatically when the URL changes.
@gwhitney gwhitney added bug Something isn't working ui Something having to do with the user interface labels Aug 23, 2024
@gwhitney
Copy link
Collaborator Author

This needs an e2e test for sure.

@gwhitney gwhitney self-assigned this Oct 29, 2024
gwhitney added a commit to gwhitney/frontscope that referenced this issue Oct 30, 2024
@gwhitney
fix: Make sure browser 'back' button actually updates specimen
edb92a9 
  Prior to this change, the browser 'back' button would always update the
  URL, but the visualization would typically not change if you were going
  from one scope URL (`/?name=Blah&...`) to another.

  This PR remedies the situation by watching for route changes in the
  Scope view, and reloading the new visualizer and sequence **into** the
  specimen already being viewed. Implementing this tactic requires the
  ability to completely change the sequence and visualizer of a specimen,
  which previously did not exist.

  The change also enables delaying specimen initialization from Vue setup()
  time to just before the component is mounted. As a result, the Vue setup
  is not asynchronous, so the experimental Vue <Suspense> tag is no longer
  needed.

  Adds a test that the back button actually took effect, to the existing
  test that changes a parameter. (The extended test definitely failed in
  ui2 prior to this PR.)

  Uses the router to redirect from an empty URL to the last-viewed specimen,
  rather than the Scope component; this change avoids reloading that specimen
  when the URL is updated to reflect what specimen is being viewed.

  Finally, fixes a small previously-existing bug in which the Differences
  visualizer could never display more terms than were available in its last
  parameter settings, even if you changed the parameters to make more
  terms available.

  Resolves numberscope#414.

  Given the large number of internal changes to Specimen.ts, please
  in review do play with a veriety of visualizations to make sure all seems
  to be working well.
@gwhitney gwhitney mentioned this issue Oct 30, 2024
Merged
katestange pushed a commit that referenced this issue Oct 31, 2024
@gwhitney
fix: Ensure back button updates visualization (#484)
5ab5bbf 
* fix: Make sure browser 'back' button actually updates specimen

  Prior to this change, the browser 'back' button would always update the
  URL, but the visualization would typically not change if you were going
  from one scope URL (`/?name=Blah&...`) to another.

  This PR remedies the situation by watching for route changes in the
  Scope view, and reloading the new visualizer and sequence **into** the
  specimen already being viewed. Implementing this tactic requires the
  ability to completely change the sequence and visualizer of a specimen,
  which previously did not exist.

  The change also enables delaying specimen initialization from Vue setup()
  time to just before the component is mounted. As a result, the Vue setup
  is not asynchronous, so the experimental Vue <Suspense> tag is no longer
  needed.

  Adds a test that the back button actually took effect, to the existing
  test that changes a parameter. (The extended test definitely failed in
  ui2 prior to this PR.)

  Uses the router to redirect from an empty URL to the last-viewed specimen,
  rather than the Scope component; this change avoids reloading that specimen
  when the URL is updated to reflect what specimen is being viewed.

  Finally, fixes a small previously-existing bug in which the Differences
  visualizer could never display more terms than were available in its last
  parameter settings, even if you changed the parameters to make more
  terms available.

  Resolves #414.

  Given the large number of internal changes to Specimen.ts, please
  in review do play with a veriety of visualizations to make sure all seems
  to be working well.

* fix: Make sure Thumbnails clean up their visualizers
@gwhitney
Copy link
Collaborator Author

Seems to work in ui2 now due to #484, so closing.

gwhitney added a commit that referenced this issue Jan 20, 2025
@gwhitney
fix: Ensure back button updates visualization (#484)
aa67483 
* fix: Make sure browser 'back' button actually updates specimen

  Prior to this change, the browser 'back' button would always update the
  URL, but the visualization would typically not change if you were going
  from one scope URL (`/?name=Blah&...`) to another.

  This PR remedies the situation by watching for route changes in the
  Scope view, and reloading the new visualizer and sequence **into** the
  specimen already being viewed. Implementing this tactic requires the
  ability to completely change the sequence and visualizer of a specimen,
  which previously did not exist.

  The change also enables delaying specimen initialization from Vue setup()
  time to just before the component is mounted. As a result, the Vue setup
  is not asynchronous, so the experimental Vue <Suspense> tag is no longer
  needed.

  Adds a test that the back button actually took effect, to the existing
  test that changes a parameter. (The extended test definitely failed in
  ui2 prior to this PR.)

  Uses the router to redirect from an empty URL to the last-viewed specimen,
  rather than the Scope component; this change avoids reloading that specimen
  when the URL is updated to reflect what specimen is being viewed.

  Finally, fixes a small previously-existing bug in which the Differences
  visualizer could never display more terms than were available in its last
  parameter settings, even if you changed the parameters to make more
  terms available.

  Resolves #414.

  Given the large number of internal changes to Specimen.ts, please
  in review do play with a veriety of visualizations to make sure all seems
  to be working well.

* fix: Make sure Thumbnails clean up their visualizers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwhitney gwhitney

Labels
bug Something isn't working ui Something having to do with the user interface
Projects
None yet
Milestone
Alpha v0.5: ui2 -> main & deploy
Development

No branches or pull requests
1 participant
@gwhitney