Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network errors on OEIS sequences lead to bad sequences being cached #407

Open
katestange opened this issue Jul 27, 2024 · 14 comments
Open
Labels
sequence Related to a sequence or the sequence subsystem

Comments

@katestange
Copy link
Member

katestange commented Jul 27, 2024

As far as I can tell, sequence A002487 is returning this.seq.first as +Infinity which is probably not good.

https://oeis.org/A002487

@katestange katestange added bug sequence Related to a sequence or the sequence subsystem labels Jul 27, 2024
@gwhitney
Copy link
Collaborator

As with #409, this sequence is seeming fine here. Changing the title of the bug to reflect that it is likely a caching error.

@gwhitney gwhitney changed the title A002487 seems to return seq.first = Infinity Network errors on OEIS sequences lead to bad sequences being cached Jul 29, 2024
gwhitney added a commit to gwhitney/frontscope that referenced this issue Jul 29, 2024
   This PR attempts to resolve numberscope#407. I added a half-dozen OEIS
   sequences as rapidly as I could and didn't get any errors.
   So hopefully this has squashed the problem, but it's hard to
   be certain.
@katestange
Copy link
Member Author

katestange commented Jul 30, 2024

Ok, I opened a different browser and cleared all browser history for all time, and then this sequence worked. But A003462 doesn't. Even with totally cleared browser history. Am I going nuts?

@katestange
Copy link
Member Author

katestange commented Jul 30, 2024

Also A000225 and A007583 fail.

But these new-to-me ones work: A115067, A000326, A003463

This is after repeatedly clearing all browser history and restarting frontscope.

The error is as reported: seq.first is Infinity and seq.last is NaN

@gwhitney
Copy link
Collaborator

Did you pull my latest PR? It supposedly has a fix, which is to say I made a change I think will help.Let me know if it does or does not.

@katestange
Copy link
Member Author

Tried -- same result.

@gwhitney
Copy link
Collaborator

OK, on new browser with cleared cache and my latest PR, when you get a sequence mess up like this, open a new tab and try the same sequence and let me know if the same sequence fails twice in a row in different tabs. Thanks!

@katestange
Copy link
Member Author

katestange commented Jul 30, 2024

Yes, still happening in multiple tabs (with cleared cache, reloaded browser and latest PR).

@katestange
Copy link
Member Author

FWIW, it's not working at the old scope at numberscope.colorado.edu either.

@katestange
Copy link
Member Author

Is it working for you?!

@katestange
Copy link
Member Author

katestange commented Jul 30, 2024

For example, go to numberscope.colorado.edu, add OEIS sequence A000225 and then try Differences -- it reports too few terms. Which is not the case on the OEIS. Or try ModFill, it pops up an error.

@gwhitney
Copy link
Collaborator

Ah, I see that https://numberscope.colorado.edu/api/get_oeis_name_and_values/A000225 is not working. So this one is a backend problem and needs to be diagnosed as such.

@gwhitney
Copy link
Collaborator

gwhitney commented Jul 30, 2024

Same thing with A003462 abd A007583.

@Vectornaut
Copy link
Collaborator

Vectornaut commented Aug 13, 2024

Of the sequences flagged above, the ones that have "crawling too fast" errors logged are:

  • A007583
  • A000225
  • A003462

These are precisely the ones that still have problems as of today. Calling get_oeis_names_and_values on them returns a "value fetching in progress" error.

There are many "crawling too fast" errors in the logs, but these are the only sequences that got a "crawling too fast" error while fetching the B-file. We think this means that the error protection for metadata requests needs to be extended to value requests.

katestange added a commit that referenced this issue Aug 15, 2024
* refactor: move the OEIS search bar into its own component.

* doc: Basic Modfill -> two OEIS-based Specimens in Gallery

* feat: Dummy search results that pop up on input

* feat: Call a dummy search cmd on input

* feat: list of links and labels for search results

* feat: Clicking on a result adds it

* fix: When you click on link in results don't also add

* feat: Actually search the OEIS.

* feat: Cache search results and reopen search on click.

* ui: Layout and caption changes per design discussions

* fix: Never cache OEIS sequences with infinite indices
   This PR attempts to resolve #407. I added a half-dozen OEIS
   sequences as rapidly as I could and didn't get any errors.
   So hopefully this has squashed the problem, but it's hard to
   be certain.

* fix: Don't update URL until after parameter values have settled
   In order to be sure that parameter values have their "final" values
   in the case of an update (e.g., by calling the Paramable validate()
   method), it is necessary for a cascade of functions to be made async.
   This commit makes those changes and then awaits the validate() in the
   user interface, so that the URL won't be updated until all of the
   consequences of validate() have occurred (which may, for example,
   involve changing the parameter values, perhaps even the one that
   originally had its tentative value modified, necessitating the validate()
   call).

   Resolves #403.

* ui: show finger cursor over search results

* make oeis.org link open new tab

* info icon for info in search results

* ui: click off list of OEIS search results closes it

* fix: Restore sequences adding when you click on them in result list.

* fix: Various fixes to OEIS search bar/results per meeting

  - Return to the OEIS ID being a link but add the Wikipedia
    "external link" icon
  - Highlight the description of each sequence as you mouse over it,
    to provide clue you can click on it (to add as a sequence). The
    color used is a lightened version of the "primary" Numberscope color.
  - Display a message when there are no sequences to show as a result
    of a search. Note this can occur because there are _too many_ matches,
    or _no_ matches, and there is no way to tell which is the case from
    the OEIS api response, unfortunately. The message reflects this.
  - Fixed bug that results were being cached under the wrong search term
    if the searcher typed more while the search was executing.
  - Make sure that enter/clicking on magnifier always fires search

* fix: Don't make switcher cards for dummy message IDs

* fix: Really make sure magnifier puts/keeps search results up; reword message

* fix: catch errors in OEIS searching and report a 'soft' failure

---------

Co-authored-by: Kate Stange <[email protected]>
@gwhitney
Copy link
Collaborator

This needs numberscope/backscope#154 to be resolved. Hence assigning to milestone beta, so as not to block alpha on backscope. But we could move it up if the team prefers and if @Vectornaut will have availability to work on the backscope part.

katestange added a commit to katestange/frontscope that referenced this issue Aug 31, 2024
* refactor: move the OEIS search bar into its own component.

* doc: Basic Modfill -> two OEIS-based Specimens in Gallery

* feat: Dummy search results that pop up on input

* feat: Call a dummy search cmd on input

* feat: list of links and labels for search results

* feat: Clicking on a result adds it

* fix: When you click on link in results don't also add

* feat: Actually search the OEIS.

* feat: Cache search results and reopen search on click.

* ui: Layout and caption changes per design discussions

* fix: Never cache OEIS sequences with infinite indices
   This PR attempts to resolve numberscope#407. I added a half-dozen OEIS
   sequences as rapidly as I could and didn't get any errors.
   So hopefully this has squashed the problem, but it's hard to
   be certain.

* fix: Don't update URL until after parameter values have settled
   In order to be sure that parameter values have their "final" values
   in the case of an update (e.g., by calling the Paramable validate()
   method), it is necessary for a cascade of functions to be made async.
   This commit makes those changes and then awaits the validate() in the
   user interface, so that the URL won't be updated until all of the
   consequences of validate() have occurred (which may, for example,
   involve changing the parameter values, perhaps even the one that
   originally had its tentative value modified, necessitating the validate()
   call).

   Resolves numberscope#403.

* ui: show finger cursor over search results

* make oeis.org link open new tab

* info icon for info in search results

* ui: click off list of OEIS search results closes it

* fix: Restore sequences adding when you click on them in result list.

* fix: Various fixes to OEIS search bar/results per meeting

  - Return to the OEIS ID being a link but add the Wikipedia
    "external link" icon
  - Highlight the description of each sequence as you mouse over it,
    to provide clue you can click on it (to add as a sequence). The
    color used is a lightened version of the "primary" Numberscope color.
  - Display a message when there are no sequences to show as a result
    of a search. Note this can occur because there are _too many_ matches,
    or _no_ matches, and there is no way to tell which is the case from
    the OEIS api response, unfortunately. The message reflects this.
  - Fixed bug that results were being cached under the wrong search term
    if the searcher typed more while the search was executing.
  - Make sure that enter/clicking on magnifier always fires search

* fix: Don't make switcher cards for dummy message IDs

* fix: Really make sure magnifier puts/keeps search results up; reword message

* fix: catch errors in OEIS searching and report a 'soft' failure

---------

Co-authored-by: Kate Stange <[email protected]>
katestange added a commit to katestange/frontscope that referenced this issue Oct 10, 2024
* refactor: move the OEIS search bar into its own component.

* doc: Basic Modfill -> two OEIS-based Specimens in Gallery

* feat: Dummy search results that pop up on input

* feat: Call a dummy search cmd on input

* feat: list of links and labels for search results

* feat: Clicking on a result adds it

* fix: When you click on link in results don't also add

* feat: Actually search the OEIS.

* feat: Cache search results and reopen search on click.

* ui: Layout and caption changes per design discussions

* fix: Never cache OEIS sequences with infinite indices
   This PR attempts to resolve numberscope#407. I added a half-dozen OEIS
   sequences as rapidly as I could and didn't get any errors.
   So hopefully this has squashed the problem, but it's hard to
   be certain.

* fix: Don't update URL until after parameter values have settled
   In order to be sure that parameter values have their "final" values
   in the case of an update (e.g., by calling the Paramable validate()
   method), it is necessary for a cascade of functions to be made async.
   This commit makes those changes and then awaits the validate() in the
   user interface, so that the URL won't be updated until all of the
   consequences of validate() have occurred (which may, for example,
   involve changing the parameter values, perhaps even the one that
   originally had its tentative value modified, necessitating the validate()
   call).

   Resolves numberscope#403.

* ui: show finger cursor over search results

* make oeis.org link open new tab

* info icon for info in search results

* ui: click off list of OEIS search results closes it

* fix: Restore sequences adding when you click on them in result list.

* fix: Various fixes to OEIS search bar/results per meeting

  - Return to the OEIS ID being a link but add the Wikipedia
    "external link" icon
  - Highlight the description of each sequence as you mouse over it,
    to provide clue you can click on it (to add as a sequence). The
    color used is a lightened version of the "primary" Numberscope color.
  - Display a message when there are no sequences to show as a result
    of a search. Note this can occur because there are _too many_ matches,
    or _no_ matches, and there is no way to tell which is the case from
    the OEIS api response, unfortunately. The message reflects this.
  - Fixed bug that results were being cached under the wrong search term
    if the searcher typed more while the search was executing.
  - Make sure that enter/clicking on magnifier always fires search

* fix: Don't make switcher cards for dummy message IDs

* fix: Really make sure magnifier puts/keeps search results up; reword message

* fix: catch errors in OEIS searching and report a 'soft' failure

---------

Co-authored-by: Kate Stange <[email protected]>
katestange added a commit to katestange/frontscope that referenced this issue Oct 13, 2024
* refactor: move the OEIS search bar into its own component.

* doc: Basic Modfill -> two OEIS-based Specimens in Gallery

* feat: Dummy search results that pop up on input

* feat: Call a dummy search cmd on input

* feat: list of links and labels for search results

* feat: Clicking on a result adds it

* fix: When you click on link in results don't also add

* feat: Actually search the OEIS.

* feat: Cache search results and reopen search on click.

* ui: Layout and caption changes per design discussions

* fix: Never cache OEIS sequences with infinite indices
   This PR attempts to resolve numberscope#407. I added a half-dozen OEIS
   sequences as rapidly as I could and didn't get any errors.
   So hopefully this has squashed the problem, but it's hard to
   be certain.

* fix: Don't update URL until after parameter values have settled
   In order to be sure that parameter values have their "final" values
   in the case of an update (e.g., by calling the Paramable validate()
   method), it is necessary for a cascade of functions to be made async.
   This commit makes those changes and then awaits the validate() in the
   user interface, so that the URL won't be updated until all of the
   consequences of validate() have occurred (which may, for example,
   involve changing the parameter values, perhaps even the one that
   originally had its tentative value modified, necessitating the validate()
   call).

   Resolves numberscope#403.

* ui: show finger cursor over search results

* make oeis.org link open new tab

* info icon for info in search results

* ui: click off list of OEIS search results closes it

* fix: Restore sequences adding when you click on them in result list.

* fix: Various fixes to OEIS search bar/results per meeting

  - Return to the OEIS ID being a link but add the Wikipedia
    "external link" icon
  - Highlight the description of each sequence as you mouse over it,
    to provide clue you can click on it (to add as a sequence). The
    color used is a lightened version of the "primary" Numberscope color.
  - Display a message when there are no sequences to show as a result
    of a search. Note this can occur because there are _too many_ matches,
    or _no_ matches, and there is no way to tell which is the case from
    the OEIS api response, unfortunately. The message reflects this.
  - Fixed bug that results were being cached under the wrong search term
    if the searcher typed more while the search was executing.
  - Make sure that enter/clicking on magnifier always fires search

* fix: Don't make switcher cards for dummy message IDs

* fix: Really make sure magnifier puts/keeps search results up; reword message

* fix: catch errors in OEIS searching and report a 'soft' failure

---------

Co-authored-by: Kate Stange <[email protected]>
gwhitney added a commit that referenced this issue Jan 20, 2025
* refactor: move the OEIS search bar into its own component.

* doc: Basic Modfill -> two OEIS-based Specimens in Gallery

* feat: Dummy search results that pop up on input

* feat: Call a dummy search cmd on input

* feat: list of links and labels for search results

* feat: Clicking on a result adds it

* fix: When you click on link in results don't also add

* feat: Actually search the OEIS.

* feat: Cache search results and reopen search on click.

* ui: Layout and caption changes per design discussions

* fix: Never cache OEIS sequences with infinite indices
   This PR attempts to resolve #407. I added a half-dozen OEIS
   sequences as rapidly as I could and didn't get any errors.
   So hopefully this has squashed the problem, but it's hard to
   be certain.

* fix: Don't update URL until after parameter values have settled
   In order to be sure that parameter values have their "final" values
   in the case of an update (e.g., by calling the Paramable validate()
   method), it is necessary for a cascade of functions to be made async.
   This commit makes those changes and then awaits the validate() in the
   user interface, so that the URL won't be updated until all of the
   consequences of validate() have occurred (which may, for example,
   involve changing the parameter values, perhaps even the one that
   originally had its tentative value modified, necessitating the validate()
   call).

   Resolves #403.

* ui: show finger cursor over search results

* make oeis.org link open new tab

* info icon for info in search results

* ui: click off list of OEIS search results closes it

* fix: Restore sequences adding when you click on them in result list.

* fix: Various fixes to OEIS search bar/results per meeting

  - Return to the OEIS ID being a link but add the Wikipedia
    "external link" icon
  - Highlight the description of each sequence as you mouse over it,
    to provide clue you can click on it (to add as a sequence). The
    color used is a lightened version of the "primary" Numberscope color.
  - Display a message when there are no sequences to show as a result
    of a search. Note this can occur because there are _too many_ matches,
    or _no_ matches, and there is no way to tell which is the case from
    the OEIS api response, unfortunately. The message reflects this.
  - Fixed bug that results were being cached under the wrong search term
    if the searcher typed more while the search was executing.
  - Make sure that enter/clicking on magnifier always fires search

* fix: Don't make switcher cards for dummy message IDs

* fix: Really make sure magnifier puts/keeps search results up; reword message

* fix: catch errors in OEIS searching and report a 'soft' failure

---------

Co-authored-by: Kate Stange <[email protected]>
@gwhitney gwhitney removed the bug label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequence Related to a sequence or the sequence subsystem
Projects
None yet
Development

No branches or pull requests

3 participants