-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmlite_linux-64_conda_builder.yml #1132
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest looks good to me.
fi | ||
CONDA_CHANNEL_DIR="conda_channel_dir" | ||
mkdir $CONDA_CHANNEL_DIR | ||
conda build --debug -c $LLVMDEV_CHANNEL --python=${{ matrix.python-version }} -c defaults conda-recipes/llvmlite" --output-folder=$CONDA_CHANNEL_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit -c defaults for warnings here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's there, following the --python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies, missed
63ea422
to
650030d
Compare
This fails on
|
The run is here: https://github.com/esc/llvmlite/actions/runs/13088442247/job/36522373118 |
Oh wow! This was due to lack of build-isolation! Let me explain, the error was triggered when running The fix is in commit: and the successful run: https://github.com/esc/llvmlite/actions/runs/13097834052 What could be causing this? |
The issue is genuine, it seems. Splitting the build and test wasn't the issue, the test job was using the wrong test command -- but that had an exit code of 0 -- so the failure wasn't detected, because the tests didn't actually run. |
Issue is fixed here: #1145 |
9c78968
to
b8d74ce
Compare
Pending #1154 |
With #1144 merged this PR will need to be updated such that it can use the artifacts produced in that workflow. |
As title
As title
As title
As title
As title
As title
1e1b991
to
fd1038e
Compare
This is done. |
As title