Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmlite_linux-64_conda_builder.yml #1132

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

esc
Copy link
Member

@esc esc commented Jan 24, 2025

As title

@esc esc added this to the v0.45.0 milestone Jan 24, 2025
@esc esc requested a review from swap357 January 24, 2025 09:02
@esc
Copy link
Member Author

esc commented Jan 24, 2025

Copy link
Contributor

@swap357 swap357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good to me.

fi
CONDA_CHANNEL_DIR="conda_channel_dir"
mkdir $CONDA_CHANNEL_DIR
conda build --debug -c $LLVMDEV_CHANNEL --python=${{ matrix.python-version }} -c defaults conda-recipes/llvmlite" --output-folder=$CONDA_CHANNEL_DIR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit -c defaults for warnings here

Copy link
Member Author

@esc esc Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's there, following the --python

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies, missed

swap357
swap357 previously approved these changes Jan 24, 2025
@esc esc force-pushed the llvmlite_linux-64_conda_builder.yml branch from 63ea422 to 650030d Compare February 1, 2025 11:34
@esc
Copy link
Member Author

esc commented Feb 1, 2025

This fails on main with:

======================================================================
FAIL: test_linux (llvmlite.tests.test_binding.TestDependencies)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/miniconda/conda-bld/llvmlite_1738411893494/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/llvmlite/tests/test_binding.py", line 727, in test_linux
    self.fail("unexpected dependency %r in %r" % (dep, deps))
AssertionError: unexpected dependency 'libzstd' in {'libdl', 'libpthread', 'libm', 'ld-linux-x86-64', 'libzstd', 'libz', 'libc', 'libgcc_s'}

@esc
Copy link
Member Author

esc commented Feb 1, 2025

This fails on main with:

The run is here: https://github.com/esc/llvmlite/actions/runs/13088442247/job/36522373118

swap357
swap357 previously approved these changes Feb 2, 2025
@esc
Copy link
Member Author

esc commented Feb 3, 2025

This fails on main with:

The run is here: https://github.com/esc/llvmlite/actions/runs/13088442247/job/36522373118

Oh wow! This was due to lack of build-isolation! Let me explain, the error was triggered when running conda build without the --no-test flag. That is the base environment has conda build installed and will make a test environment and after building the package execute the tests in a special (supposedly isolated) test environment. However this causes the bug above. The fix is to do the testing in a fresh GHA job using the command conda build --test llvmlite*.conda on the previously generated artifact. In that case, we are also using the test functionality of conda build but the test passes!

The fix is in commit:

017554d

and the successful run:

https://github.com/esc/llvmlite/actions/runs/13097834052

What could be causing this?

@esc
Copy link
Member Author

esc commented Feb 3, 2025

This fails on main with:

The run is here: https://github.com/esc/llvmlite/actions/runs/13088442247/job/36522373118

Oh wow! This was due to lack of build-isolation! Let me explain, the error was triggered when running conda build without the --no-test flag. That is the base environment has conda build installed and will make a test environment and after building the package execute the tests in a special (supposedly isolated) test environment. However this causes the bug above. The fix is to do the testing in a fresh GHA job using the command conda build --test llvmlite*.conda on the previously generated artifact. In that case, we are also using the test functionality of conda build but the test passes!

The fix is in commit:

017554d

and the successful run:

https://github.com/esc/llvmlite/actions/runs/13097834052

What could be causing this?

The issue is genuine, it seems. Splitting the build and test wasn't the issue, the test job was using the wrong test command -- but that had an exit code of 0 -- so the failure wasn't detected, because the tests didn't actually run.

@esc
Copy link
Member Author

esc commented Feb 3, 2025

ref: conda/conda-build#5612

@esc
Copy link
Member Author

esc commented Feb 4, 2025

This fails on main with:

======================================================================
FAIL: test_linux (llvmlite.tests.test_binding.TestDependencies)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/miniconda/conda-bld/llvmlite_1738411893494/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/llvmlite/tests/test_binding.py", line 727, in test_linux
    self.fail("unexpected dependency %r in %r" % (dep, deps))
AssertionError: unexpected dependency 'libzstd' in {'libdl', 'libpthread', 'libm', 'ld-linux-x86-64', 'libzstd', 'libz', 'libc', 'libgcc_s'}

Issue is fixed here: #1145

@esc esc force-pushed the llvmlite_linux-64_conda_builder.yml branch 2 times, most recently from 9c78968 to b8d74ce Compare February 6, 2025 12:20
@esc esc mentioned this pull request Feb 6, 2025
@esc
Copy link
Member Author

esc commented Feb 6, 2025

Pending #1154

@esc
Copy link
Member Author

esc commented Feb 6, 2025

With #1144 merged this PR will need to be updated such that it can use the artifacts produced in that workflow.

@esc esc force-pushed the llvmlite_linux-64_conda_builder.yml branch from 1e1b991 to fd1038e Compare February 6, 2025 15:58
@esc
Copy link
Member Author

esc commented Feb 6, 2025

With #1144 merged this PR will need to be updated such that it can use the artifacts produced in that workflow.

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants