LLVM 15 conda recipe #1036
LLVM 15 conda recipe #1036
Conversation
LLVM ERROR: Tried to execute an unknown external function: roundevenf
|
f0def58 builds successfully on all platform in the buildfarm |
|
passed numba testsuite when running manually on linux-64 machine |
This is a backport of: ``` commit 7939ce39dac0078fef7183d6198598b99c652c88 Author: Jon Roelofs <[email protected]> Date: Fri Nov 17 14:21:57 2023 -0800 [builtins] Move cfi start's after the symbol name [NFC] ... in preparation for diagnosing improperly nested .cfi regions. See https://reviews.llvm.org/D155245 ``` The ordering of `.cfi_startproc` and the function name in compiler-rt's `assembly.h` triggers a new diagnostic about improperly nested `.cfi` regions in Clang 18 onwards. This is fixed in compiler-rt upstream, but needs to be applied to compiler-rt from LLVM 15 because we're building it with Clang 18 in some cases. References to discussions of the issue: - rust-lang/llvm-project@8238831 - https://issues.chromium.org/issues/40945072
The symbols in the compiler-rt builtins library are private external by default on MacOS. We need them to be visible so we can link against them (e.g. when building libllvmlite.so). This patch makes the symbols visible when the CMake option `COMPILER_RT_BUILTINS_HIDE_SYMBOLS` is off. Note that this is an existing option for the compiler-rt build, and the flags requiring modification in this patch appear to be an oversight. References: - https://discourse.llvm.org/t/lld-automatically-hide-symbols-with-prefix/73192 - numba#986 (comment)
This enables the build of compiler-rt builtins with the following changes: - Add `compiler-rt` to the list of LLVM projects to build - Disable the build of all `compiler-rt` components except for the builtins. Whilst it would be interesting to add these, they seem to require clang to be built at the same time. - Setting the `COMPILER_RT_BUILTINS_HIDE_SYMBOLS` CMake option to `OFF`, to ensure that we can link against those symbols in the general case. Note that these changes are simpler than previous efforts towards enabling `compiler-rt` builtins (e.g. numba#979) - this is because we now build as part of the whole `llvm-project` tree, which simplifies things and removes issues that had to be worked around when building it separately.
Add compiler-rt build for LLVM 15
|
Thanks all! 🙏 Given support for LLVM 15 was added in PR ( #1035 ), what is still needed here? |
|
We need to merge this and build the llvmdev package, as I understand it. (This requires the setup internal to Anaconda on their build farm). After that, I think we can switch the llvmlite CI over to use LLVM 15 by default, and start to move it from being experimental to being the default supported version. |
|
BFID |
build passed |
sklam
added
BuildFarm Passed
|
Now testing llvmdev build against llvmlite test in |
|
|
There was a problem hiding this comment.
I had previously reviewed this and tested it locally and my understanding is that we were only waiting on a build farm run, so I think this is OK to move to RTM and build new LLVMdev 15 packages for the main channel so we can switch llvmlite over to more general testing with LLVM 15.
|
Marked RTM as per discussion in triage meeting. |
No description provided.