Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate collection jump to functionality in search component. #380

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Sep 3, 2024

What does this do?

This work integrates more fully the JumpTo component intended for our Collections page within our Search.tsx component. Previously we had broken out a seperate search component specifically for the collection pages. With the advent of the Use Generative AI toggle, this different strategy for collection pages left the search component there lacking our nice updates.

We now determine if we are on a collection route and then use this boolean to append the JumpTo component below the search component.

image

How do we review?

  • Go to
    https://5166-preview.dc.rdc-staging.library.northwestern.edu or your dev DC
  • Go to any Collection, ex: 16th-Early 20th Century Maps of Africa
  • Your should not see the JumpTo component
  • Begin typing, "Sudan"
  • JumpTo listbox should expand below the search component
  • Links JumpTo listbox options allow for searching "In This Collection" or "All Digital Collections"
  • "In This Collection" option will navigate the user the /search route with the Collection faceted and the query string matching, ex "Sudan"

Notes:

  • This should work with Use Generative AI toggled either way
  • This should be fully responsive and collapse appropriately in small viewports
  • The JumpTo options should not be present on other routes, include the Browse Collections /collections page

@mathewjordan mathewjordan requested review from adamjarling and kdid and removed request for adamjarling September 4, 2024 14:10
@mathewjordan mathewjordan self-assigned this Sep 4, 2024
@mathewjordan mathewjordan marked this pull request as ready for review September 4, 2024 14:11
Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as advertised!

@mathewjordan mathewjordan force-pushed the preview/5166-collection-route-search branch from 9c9382f to 09d4ae0 Compare September 4, 2024 14:29
@mathewjordan mathewjordan merged commit b06edea into deploy/staging Sep 4, 2024
1 check passed
@mathewjordan mathewjordan deleted the preview/5166-collection-route-search branch September 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants