Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist results tab if paging or facets are adjusted #355

Merged

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Jul 26, 2024

What does this do?

This adjusts how we are setting the active tab on search results page.

  • Makes results the "default"
  • Uses the router.query q to adjust tabs if new search sent through

@mathewjordan mathewjordan changed the base branch from deploy/staging to preview/chat-integration July 26, 2024 16:51
@mathewjordan mathewjordan changed the title preview/5122 persist results tab Persist results tab if paging or facets are adjusted Jul 26, 2024
@mathewjordan mathewjordan marked this pull request as ready for review July 26, 2024 16:52
@mathewjordan mathewjordan force-pushed the preview/5122-persist-results-tab branch 2 times, most recently from 5106829 to 145cf32 Compare July 26, 2024 16:53
@mathewjordan mathewjordan force-pushed the preview/5122-persist-results-tab branch from 145cf32 to 1d75ddc Compare July 26, 2024 16:54
@mathewjordan mathewjordan requested a review from adamjarling July 26, 2024 16:55
@mathewjordan mathewjordan self-assigned this Jul 26, 2024
Copy link
Contributor

@adamjarling adamjarling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@mathewjordan mathewjordan merged commit bff449d into preview/chat-integration Jul 26, 2024
1 check passed
@mathewjordan mathewjordan deleted the preview/5122-persist-results-tab branch July 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants