Refine TextArea UX, overall header styling. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewjordan
force-pushed
the
5045-textarea-ux
branch
from
34802ea to
883f5e5
Compare
mathewjordan
changed the title
adamjarling
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work refines the Search component and textarea UX. Now when a user begins to type, the
<textarea>element will grow in by calculating thescrollHeightof the element and applying this height as a style. If the user unfocuses, the height should transition back to the default height (appx 50px) with atext-overflowrendering an ellipsis for overflowing textual content.To make this blend well with our current layout, I opted to simplify the background colors, making the previous background of purple now transparent and showing white. This should elevate the actionable elements in the header to the foreground.
Along with this, I also made some other stylistic updates regarding overall legibility of text in the
htmldocument, sharpening and modernizing things. Along with this, I also updated the styling of the AI Response / ViewnResults tab.Other Notes
I needed to refine some
Searchcomponents tests after making modifications. Mainily, I removed the need for us to knowisSearchActiveon the Generative AI toggle which was only used for margins. These updates should simplify things there.I needed to mock the ResizeObserver as Radix was screaming about this for some reason (see jest.setup)