Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Cypress End to End Test starter #268

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Integrate Cypress End to End Test starter #268

merged 1 commit into from
Apr 19, 2023

Conversation

adamjarling
Copy link
Contributor

What does this do?

  • Sets up the framework for running E2E tests against the DC Test Environment from a dev's local laptop DC v2 dev environment (not sure this would work in our AWS space yet)
  • Implements E2E tests against the Search page
  • Implements starter E2E tests against the Home page

How to Test

  • Run the E2E tests locally (see the README, as this will prove whether the instructions are complete or clear enough)

@adamjarling adamjarling self-assigned this Apr 11, 2023
@adamjarling adamjarling marked this pull request as ready for review April 13, 2023 16:53
mathewjordan
mathewjordan approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and I'm happy to have the framework in here now for handling these. Just the one change request but don't want to hold it up. Maybe just accept my suggestion here and pull it through?

cypress/e2e/search/search.cy.ts Outdated Show resolved Hide resolved
@adamjarling adamjarling force-pushed the 3540-cypress-search branch from f3e97a0 to 5ec28d6 Compare April 19, 2023 18:15
@adamjarling adamjarling merged commit 670f2a4 into deploy/staging Apr 19, 2023
@adamjarling adamjarling deleted the 3540-cypress-search branch April 19, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewjordan mathewjordan mathewjordan approved these changes

Assignees

@adamjarling adamjarling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjarling @mathewjordan