Add basic 404. #247
Merged
Add basic 404. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewjordan
force-pushed
the
preview/3587-404
branch
from
671110a to
9fd0ab0
Compare
adamjarling
reviewed
Feb 21, 2023
mathewjordan
force-pushed
the
preview/3587-404
branch
from
9fd0ab0 to
7064c99
Compare
adamjarling
approved these changes
Mar 9, 2023
| @@ -203,6 +203,11 @@ export const getServerSideProps: GetServerSideProps = async (context) => { | |||
| const id = context?.params?.id; | |||
| const collection = await getCollection(id as string); | |||
|
|
|||
| if (typeof collection === "undefined") | |||
| return { | |||
| notFound: true, | |||
mathewjordan
force-pushed
the
preview/3587-404
branch
from
7064c99 to
510f8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This work adds a basic custom 404 page. The page is basically just reusing the Hero component on the homepage to render a single slide. Additionally, it adds navigation to the end user to direct them back to actual content.
The image itself can be easily swapped out by adjusting a IIIF thumbnail on the pageNotFoundCollection object at
lib/constants/404.tsif we decided on different one.I also fixed a small bug in the HeroBasic component where the
bgImageprop does not drill down as expected to some inline CSS. This was notice when working through an initial idea.