Add an API route and rewrites to fetch sitemaps from an S3 bucket #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjarling
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes needed to deliver sitemaps from the root of the server without having to trigger a build every time the sitemap changes.
/api/sitemap/:filenameto stream content from the sitemap bucket to the client/sitemap*to/api/sitemap/sitemap*without redirecting the clientResults can be seen in the preview branch at https://preview-sitemap-bucket.d2v1qbdeix3nr2.amplifyapp.com/sitemap.xml
There is a companion PR to tell Meadow about the new sitemap location and have it generate the proper index file