Work modals responsive fix #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewjordan
requested changes
Feb 7, 2023
components/BloomWrapper.tsx
Outdated
| @@ -14,6 +14,18 @@ const StyledBloomIIIFWrapper = styled("div", { | |||
| ".swiper-slide[data-type='collection']": { | |||
| display: "none", | |||
| }, | |||
|
|
|||
| "@sm": { | |||
| "& > div > div": { | |||
There was a problem hiding this comment.
Good for now but man I hate this div cascade. Some near future tech debt to come in and make these targets more specific. Also could just be a Bloom thing too?
| <div> | ||
| <Heading as="h2">All Subjects</Heading> | ||
| <> | ||
| <Heading as="h2" css={{ "@sm": { textAlign: "center" } }}> |
There was a problem hiding this comment.
Oh way, mediaQuery in a css prop. I had not tried that. 🧙
components/Shared/Dialog.tsx
Outdated
| @@ -29,6 +29,7 @@ const SharedDialog: React.FC<SharedDialogProps> = ({ | |||
| <Dialog.Portal> | |||
| <DialogOverlay /> | |||
| <DialogContent | |||
| data-id="adam" | |||
There was a problem hiding this comment.
This can be thrown out, right? 🗑️
adamjarling
force-pushed
the
3313-work-modals
branch
from
bb5473d to
30439d9
Compare
mathewjordan
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates Work modals (Find / Cite / Download) to behave better on mobile/tablet.
Before
After