Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode Collection title in Collection page View button #210

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Encode Collection title in Collection page View button #210

merged 1 commit into from
Feb 3, 2023

Conversation

adamjarling
Copy link
Contributor

@adamjarling adamjarling commented Feb 3, 2023 •
edited
Loading

What does this do?

  • Encodes the Collection title in Collection page View button.
  • Updates @nulib/dcapi-types package to latest version

image

image

How to test

Click on the view button and the resulting Search page should respect the Collection filter.

@adamjarling adamjarling self-assigned this Feb 3, 2023
@adamjarling adamjarling merged commit 61c05f9 into deploy/staging Feb 3, 2023
@adamjarling adamjarling deleted the 3543-obama-fix branch February 3, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdid kdid kdid approved these changes

@mathewjordan mathewjordan Awaiting requested review from mathewjordan

Assignees

@adamjarling adamjarling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjarling @kdid