Try wait-on package to get tests to run in Github workflow

nulib · Mar 29, 2024 · 10f232d · 10f232d
1 parent 6c07dda
commit 10f232d
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 5 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -15,8 +15,6 @@ jobs:
           node-version: 18
       - name: Install dependencies
         run: npm ci
-        env:
-          BASE_URL: ${{ secrets.BASE_URL }}
 
       - name: Install Playwright Browsers
         run: npx playwright install --with-deps
@@ -25,10 +23,15 @@ jobs:
         run: npm run build
 
       - name: Start app
-        run: npm run start
+        run: npm run start &
+
+      - name: Wait for server
+        run: npx wait-on http://localhost:3000
 
       - name: Run Playwright tests
         run: npx playwright test
+        env:
+          BASE_URL: ${{ secrets.BASE_URL }}
 
       - uses: actions/upload-artifact@v3
         if: always()

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -79,7 +79,8 @@
     "next-router-mock": "^0.9.1-beta.0",
     "prettier": "^3.0.1",
     "ts-jest": "^29.0.5",
-    "typescript": "^5.4.2"
+    "typescript": "^5.4.2",
+    "wait-on": "^7.2.0"
   },
   "optionalDependencies": {
     "fsevents": "^2.3.2"