Update common to 0.3.6

.scalafix.conf

@@ -0,0 +1 @@
+include "common/.scalafix.conf"

.scalafmt.conf

@@ -1,3 +1 @@
-version = 2.5.1
-
 include "common/.scalafmt.conf"

build.sbt

@@ -2,6 +2,13 @@ lazy val commonSettings = Seq(
   organization := "com.nulabinc",
   version := "0.6.2-SNAPSHOT",
   scalaVersion := "2.13.6",
+  scalacOptions ++= Seq(
+    "-deprecation",
+    "-feature",
+    "-unchecked",
+    "-Xlint",
+    "-Wunused"
+  ),
   libraryDependencies ++= {
     val spec2Version = "4.8.3"
     Seq(
@@ -14,7 +21,11 @@ lazy val commonSettings = Seq(
     )
   },
   javacOptions ++= Seq("-encoding", "UTF-8"),
-  assembly / test := {}
+  assembly / test := {},
+  // scalafix
+  addCompilerPlugin(scalafixSemanticdb),
+  semanticdbEnabled := true,
+  semanticdbVersion := scalafixSemanticdb.revision
 )
 
 lazy val common = (project in file("common")).settings(commonSettings)
@@ -38,3 +49,16 @@ lazy val root = (project in file("."))
   )
   .dependsOn(common % "test->test;compile->compile", client)
   .aggregate(common, client)
+
+addCommandAlias(
+  "fixAll",
+  "all compile:scalafix; test:scalafix; scalafmt; test:scalafmt; scalafmtSbt"
+)
+addCommandAlias(
+  "checkAll",
+  "compile:scalafix --check; test:scalafix --check; scalafmtCheck; test:scalafmtCheck; scalafmtSbtCheck"
+)
+
+ThisBuild / scalafixDependencies += "com.github.liancheng" %% "organize-imports" % "0.5.0"
+
+Global / onChangedBuildSource := ReloadOnSourceChanges

jira-client/build.sbt

@@ -1,13 +1,13 @@
 name := "jira-client"
 
 libraryDependencies ++= Seq(
-  "org.apache.httpcomponents" % "httpclient"            % "4.5.3",
-  "io.spray"                  %% "spray-json"           % "1.3.5",
-  "io.lemonlabs"              %% "scala-uri"            % "1.5.1",
-  "org.slf4j"                 % "slf4j-api"             % "1.7.25",
-  "org.scalatest"             %% "scalatest"            % "3.0.5" % "test",
-  "org.specs2"                %% "specs2-core"          % "3.8.9" % Test,
-  "org.specs2"                %% "specs2-matcher"       % "3.8.9" % Test,
-  "org.specs2"                %% "specs2-matcher-extra" % "3.8.9" % Test,
-  "org.specs2"                %% "specs2-mock"          % "3.8.9" % Test
+  "org.apache.httpcomponents" % "httpclient"           % "4.5.3",
+  "io.spray"                 %% "spray-json"           % "1.3.5",
+  "io.lemonlabs"             %% "scala-uri"            % "1.5.1",
+  "org.slf4j"                 % "slf4j-api"            % "1.7.25",
+  "org.scalatest"            %% "scalatest"            % "3.0.5" % "test",
+  "org.specs2"               %% "specs2-core"          % "3.8.9" % Test,
+  "org.specs2"               %% "specs2-matcher"       % "3.8.9" % Test,
+  "org.specs2"               %% "specs2-matcher-extra" % "3.8.9" % Test,
+  "org.specs2"               %% "specs2-mock"          % "3.8.9" % Test
 )

jira-client/src/main/scala/com/nulabinc/jira/client/apis/CommentAPI.scala

@@ -1,8 +1,8 @@
 package com.nulabinc.jira.client.apis
 
-import io.lemonlabs.uri.dsl._
 import com.nulabinc.jira.client._
 import com.nulabinc.jira.client.domain.CommentResult
+import io.lemonlabs.uri.dsl._
 import spray.json._
 
 class CommentAPI(httpClient: HttpClient) extends Pageable {

jira-client/src/main/scala/com/nulabinc/jira/client/apis/IssueAPI.scala

@@ -1,9 +1,9 @@
 package com.nulabinc.jira.client.apis
 
-import io.lemonlabs.uri.dsl._
 import com.nulabinc.jira.client._
 import com.nulabinc.jira.client.domain.changeLog.{ChangeLog, ChangeLogResult}
 import com.nulabinc.jira.client.domain.issue.Issue
+import io.lemonlabs.uri.dsl._
 import spray.json._
 
 case class IssueResult(total: Int, issues: Seq[Issue])

jira-client/src/main/scala/com/nulabinc/jira/client/apis/SearchAPI.scala

@@ -1,8 +1,8 @@
 package com.nulabinc.jira.client.apis
 
-import io.lemonlabs.uri.dsl._
 import com.nulabinc.jira.client._
 import com.nulabinc.jira.client.domain.SearchResult
+import io.lemonlabs.uri.dsl._
 import spray.json.JsonParser
 
 class SearchAPI(httpClient: HttpClient) extends Pageable {

jira-client/src/main/scala/com/nulabinc/jira/client/apis/UserAPI.scala

@@ -2,9 +2,9 @@ package com.nulabinc.jira.client.apis
 
 import java.net.URLEncoder
 
-import io.lemonlabs.uri.dsl._
 import com.nulabinc.jira.client._
 import com.nulabinc.jira.client.domain.User
+import io.lemonlabs.uri.dsl._
 import spray.json.JsonParser
 
 class UserAPI(httpClient: HttpClient) {

jira-client/src/main/scala/com/nulabinc/jira/client/json/ChangeLogMappingJsonProtocol.scala

@@ -2,8 +2,8 @@ package com.nulabinc.jira.client.json
 
 import java.util.Date
 
-import com.nulabinc.jira.client.domain.{changeLog, _}
 import com.nulabinc.jira.client.domain.changeLog._
+import com.nulabinc.jira.client.domain.{changeLog, _}
 import spray.json.{JsNull, _}
 
 object ChangeLogMappingJsonProtocol extends DefaultJsonProtocol {

jira-client/src/test/scala/com/nulabinc/jira/client/apis/impl/ProjectAPISpec.scala

@@ -1,7 +1,7 @@
 package com.nulabinc.jira.client.apis.impl
 
-import com.nulabinc.jira.client.apis.ProjectAPI
 import com.nulabinc.jira.client.HttpClient
+import com.nulabinc.jira.client.apis.ProjectAPI
 import com.nulabinc.jira.client.domain.Project
 import org.specs2.mock.Mockito
 import org.specs2.mutable.Specification

project/plugins.sbt

@@ -1,7 +1,6 @@
 logLevel := Level.Warn
 
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.9")
-
-addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.2")
-
+addSbtPlugin("com.eed3si9n"  % "sbt-assembly"  % "0.14.9")
+addSbtPlugin("org.scalameta" % "sbt-scalafmt"  % "2.4.2")
+addSbtPlugin("ch.epfl.scala" % "sbt-scalafix"  % "0.9.29")
 addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.5.1")

src/main/scala/com/nulabinc/backlog/j2b/cli/J2BCli.scala

@@ -1,5 +1,7 @@
 package com.nulabinc.backlog.j2b.cli
 
+import java.nio.file.{Path, Paths}
+
 import com.google.inject.Guice
 import com.nulabinc.backlog.j2b._
 import com.nulabinc.backlog.j2b.conf.{AppConfigValidator, AppConfiguration}
@@ -12,7 +14,6 @@ import com.nulabinc.backlog.j2b.jira.writer.ProjectUserWriter
 import com.nulabinc.backlog.j2b.mapping.converter.MappingConvertService
 import com.nulabinc.backlog.j2b.mapping.converter.writes.MappingUserWrites
 import com.nulabinc.backlog.j2b.modules._
-import com.nulabinc.backlog.j2b.persistence.store
 import com.nulabinc.backlog.j2b.persistence.store.JiraSQLiteStoreDSL
 import com.nulabinc.backlog.migration.common.conf.{
   BacklogConfiguration,
@@ -35,9 +36,9 @@ import com.nulabinc.backlog.migration.common.interpreters.{
 import com.nulabinc.backlog.migration.common.messages.ConsoleMessages
 import com.nulabinc.backlog.migration.common.modules.{ServiceInjector => BacklogInjector}
 import com.nulabinc.backlog.migration.common.service.{
+  PriorityService => BacklogPriorityService,
   ProjectService,
   SpaceService,
-  PriorityService => BacklogPriorityService,
   StatusService => BacklogStatusService,
   UserService => BacklogUserService
 }
@@ -54,8 +55,6 @@ import com.osinka.i18n.Messages
 import monix.eval.Task
 import monix.execution.Scheduler
 
-import java.nio.file.{Path, Paths}
-
 object J2BCli
     extends BacklogConfiguration
     with Logging
@@ -251,7 +250,7 @@ object J2BCli
       storeDSL: StoreDSL[Task]
   ): Task[Either[AppError, Unit]] = {
     val result = Boot
-      .execute[Task](config.backlogConfig, false, config.retryCount)
+      .execute(config.backlogConfig, false, config.retryCount)
       .mapError[AppError](e => UnknownError(e))
       .handleError
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/CommentFileWriter.scala

@@ -1,6 +1,7 @@
 package com.nulabinc.backlog.j2b.exporter
 
 import java.util.Date
+import javax.inject.Inject
 
 import com.nulabinc.backlog.j2b.issue.writer.convert._
 import com.nulabinc.backlog.j2b.jira.service.IssueService
@@ -11,7 +12,6 @@ import com.nulabinc.backlog.migration.common.domain._
 import com.nulabinc.backlog.migration.common.utils.IOUtil
 import com.nulabinc.jira.client.domain._
 import com.nulabinc.jira.client.domain.changeLog.ChangeLog
-import javax.inject.Inject
 import spray.json._
 
 class CommentFileWriter @Inject() (

src/main/scala/com/nulabinc/backlog/j2b/exporter/Exporter.scala

@@ -1,5 +1,7 @@
 package com.nulabinc.backlog.j2b.exporter
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.exporter.console.RemainingTimeCalculator
 import com.nulabinc.backlog.j2b.jira.conf.JiraBacklogPaths
 import com.nulabinc.backlog.j2b.jira.domain.export._
@@ -24,7 +26,6 @@ import com.nulabinc.jira.client.domain.changeLog.{
 }
 import com.nulabinc.jira.client.domain.issue._
 import com.osinka.i18n.Messages
-import javax.inject.Inject
 import monix.eval.Task
 
 class Exporter @Inject() (

src/main/scala/com/nulabinc/backlog/j2b/exporter/IssueFileWriter.scala

@@ -1,14 +1,14 @@
 package com.nulabinc.backlog.j2b.exporter
 
 import java.util.Date
+import javax.inject.Inject
 
 import com.nulabinc.backlog.j2b.jira.service.IssueService
 import com.nulabinc.backlog.j2b.jira.writer.IssueWriter
 import com.nulabinc.backlog.migration.common.conf.BacklogPaths
 import com.nulabinc.backlog.migration.common.domain.BacklogIssue
 import com.nulabinc.backlog.migration.common.formatters.BacklogJsonProtocol._
 import com.nulabinc.backlog.migration.common.utils.IOUtil
-import javax.inject.Inject
 import spray.json._
 
 class IssueFileWriter @Inject() (

src/main/scala/com/nulabinc/backlog/j2b/exporter/IssueInitializer.scala

@@ -1,5 +1,7 @@
 package com.nulabinc.backlog.j2b.exporter
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.issue.writer.convert._
 import com.nulabinc.backlog.j2b.jira.domain.export._
 import com.nulabinc.backlog.j2b.jira.domain.mapping.MappingCollectDatabase
@@ -11,7 +13,6 @@ import com.nulabinc.backlog.migration.common.utils._
 import com.nulabinc.jira.client.domain.Comment
 import com.nulabinc.jira.client.domain.changeLog._
 import com.nulabinc.jira.client.domain.issue.Issue
-import javax.inject.Inject
 
 class IssueInitializer @Inject() (
     implicit val issueWrites: IssueWrites,

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientCategoryService.scala

@@ -1,9 +1,10 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.domain.JiraProjectKey
 import com.nulabinc.backlog.j2b.jira.service.CategoryService
 import com.nulabinc.jira.client.JiraRestClient
-import javax.inject.Inject
 
 class JiraClientCategoryService @Inject() (
     jira: JiraRestClient,

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientCommentService.scala

@@ -1,10 +1,11 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.service.CommentService
 import com.nulabinc.jira.client.JiraRestClient
 import com.nulabinc.jira.client.domain.Comment
 import com.nulabinc.jira.client.domain.issue.Issue
-import javax.inject.Inject
 
 class JiraClientCommentService @Inject() (jira: JiraRestClient) extends CommentService {
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientFieldService.scala

@@ -1,8 +1,9 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.service.FieldService
 import com.nulabinc.jira.client.JiraRestClient
-import javax.inject.Inject
 
 class JiraClientFieldService @Inject() (jira: JiraRestClient) extends FieldService {
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientIssueService.scala

@@ -1,6 +1,7 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
 import java.net.URLEncoder
+import javax.inject.Inject
 
 import better.files.{File => Path}
 import com.nulabinc.backlog.j2b.jira.domain.JiraProjectKey
@@ -9,7 +10,6 @@ import com.nulabinc.backlog.migration.common.utils.Logging
 import com.nulabinc.jira.client.domain.changeLog.ChangeLog
 import com.nulabinc.jira.client.domain.issue.Issue
 import com.nulabinc.jira.client.{DownloadResult, JiraRestClient}
-import javax.inject.Inject
 
 class JiraClientIssueService @Inject() (
     projectKey: JiraProjectKey,

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientIssueTypeService.scala

@@ -1,8 +1,9 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.service.IssueTypeService
 import com.nulabinc.jira.client.JiraRestClient
-import javax.inject.Inject
 
 class JiraClientIssueTypeService @Inject() (jira: JiraRestClient) extends IssueTypeService {
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientPriorityService.scala

@@ -1,8 +1,9 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.service.PriorityService
 import com.nulabinc.jira.client.JiraRestClient
-import javax.inject.Inject
 
 class JiraClientPriorityService @Inject() (jira: JiraRestClient) extends PriorityService {
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientProjectService.scala

@@ -1,10 +1,11 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.domain.JiraProjectKey
 import com.nulabinc.backlog.j2b.jira.service.ProjectService
 import com.nulabinc.jira.client.JiraRestClient
 import com.nulabinc.jira.client.domain.Project
-import javax.inject.Inject
 import monix.eval.Task
 
 class JiraClientProjectService @Inject() (jiraRestClient: JiraRestClient)

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientStatusService.scala

@@ -1,10 +1,11 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.service.StatusService
 import com.nulabinc.backlog.migration.common.utils.Logging
 import com.nulabinc.jira.client.JiraRestClient
 import com.nulabinc.jira.client.domain.Status
-import javax.inject.Inject
 
 class JiraClientStatusService @Inject() (jira: JiraRestClient) extends StatusService with Logging {
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientUserService.scala

@@ -1,10 +1,11 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.service.UserService
 import com.nulabinc.backlog.migration.common.utils.Logging
 import com.nulabinc.jira.client.JiraRestClient
 import com.nulabinc.jira.client.domain.User
-import javax.inject.Inject
 
 class JiraClientUserService @Inject() (jira: JiraRestClient) extends UserService with Logging {
 

src/main/scala/com/nulabinc/backlog/j2b/exporter/service/JiraClientVersionService.scala

@@ -1,9 +1,10 @@
 package com.nulabinc.backlog.j2b.exporter.service
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.jira.domain.JiraProjectKey
 import com.nulabinc.backlog.j2b.jira.service.VersionService
 import com.nulabinc.jira.client.JiraRestClient
-import javax.inject.Inject
 
 class JiraClientVersionService @Inject() (
     jira: JiraRestClient,

src/main/scala/com/nulabinc/backlog/j2b/issue/writer/ComponentFileWriter.scala

@@ -1,13 +1,14 @@
 package com.nulabinc.backlog.j2b.issue.writer
 
+import javax.inject.Inject
+
 import com.nulabinc.backlog.j2b.issue.writer.convert.ComponentWrites
 import com.nulabinc.backlog.j2b.jira.writer.ComponentWriter
 import com.nulabinc.backlog.migration.common.conf.BacklogPaths
 import com.nulabinc.backlog.migration.common.convert.Convert
 import com.nulabinc.backlog.migration.common.domain.BacklogIssueCategoriesWrapper
 import com.nulabinc.backlog.migration.common.utils.IOUtil
 import com.nulabinc.jira.client.domain.Component
-import javax.inject.Inject
 import spray.json._
 
 class ComponentFileWriter @Inject() (implicit