Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: controller image as an input parameter #44

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

AndriyKalashnykov
Copy link
Contributor

@AndriyKalashnykov AndriyKalashnykov commented Jun 25, 2022

Fixes #41

@scottd018
Copy link
Contributor

@AndriyKalashnykov this looks good. The only thing we need to fix is the PR title and the commit messages to align with https://www.conventionalcommits.org/en/v1.0.0/ . The reason we do this is so that our release notes look consistent upon release, as they are tied back to the individual commit messages.

You'll need to:

git rebase -i HEAD~2

And fix the feature: commit message. You can simply change it to feat: or you can merge the 2 commits together (whichever you prefer). Once that's done, you can force push and we should be all good.

@AndriyKalashnykov AndriyKalashnykov changed the title feature: controller image as an input parameter feat: controller image as an input parameter Jun 27, 2022
@AndriyKalashnykov AndriyKalashnykov merged commit 4fcf7c9 into main Jun 27, 2022
@AndriyKalashnykov AndriyKalashnykov deleted the issue-41 branch July 17, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: take in controller image as an input and update Makefile
2 participants