feat: upgrade to go version 1.18 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
cases.Title is set to replace strings.Title, but it does not return the same. We consider a 'title' of a field of collection.spec.name to read collection.Spec.Name, but the new method returns collection.Spec.name instead. Only the first field is capitalized and the rest are lowercased. We will use the deprecated method until we can figure out how to make it return appropriately. Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
Signed-off-by: Dustin Scott <[email protected]>
This commit upgrades the kustomize version as the old version is imcompatible with the way it was importing its packages in go1.18. It also adjusts the controller-gen options to account for a newer version of controller-gen by removing the deprecated options. Signed-off-by: Dustin Scott <[email protected]>
Also centralized the preferred and minimum version variables into a version file in utils package to assist with future upgrades. Signed-off-by: Dustin Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is addressed with this PR:
desiredpackage, we can now more accurately determine when a resource is in its true desired state (client-side) or whether it is not and needs reconciliation. This fixes this issue as the old methodology was inaccurate.