Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 33 #1759

Merged
merged 31 commits into from
Feb 16, 2025

Add more logging around listening history

8888512
Select commit
Loading
Failed to load commit list.
Merged

Electron 33 #1759

Add more logging around listening history
8888512
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 16, 2025 in 0s

68.71% (-1.25%) compared to ded6d7f

View this Pull Request on Codecov

68.71% (-1.25%) compared to ded6d7f

Details

Codecov Report

Attention: Patch coverage is 61.89320% with 157 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (ded6d7f) to head (8888512).

Files with missing lines Patch % Lines
packages/core/src/logger/nuclear-logger.ts 25.35% 70 Missing and 36 partials ⚠️
.../lib/components/GridTrackTable/Cells/TitleCell.tsx 20.00% 8 Missing ⚠️
packages/app/app/actions/downloads.ts 54.54% 5 Missing ⚠️
packages/app/app/actions/local.ts 37.50% 4 Missing and 1 partial ⚠️
...es/app/app/components/TagView/TagTopList/index.tsx 60.00% 1 Missing and 3 partials ⚠️
packages/app/app/components/Settings/index.tsx 40.00% 2 Missing and 1 partial ⚠️
packages/app/app/components/TagView/index.tsx 90.90% 2 Missing and 1 partial ⚠️
...ages/app/app/containers/TagViewContainer/index.tsx 86.36% 3 Missing ⚠️
packages/core/src/plugins/lyrics/azlyrics.ts 25.00% 3 Missing ⚠️
packages/core/src/plugins/stream/AudiusPlugin.ts 25.00% 3 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   69.96%   68.71%   -1.25%     
==========================================
  Files         382      377       -5     
  Lines        7518     7573      +55     
  Branches      580      617      +37     
==========================================
- Hits         5260     5204      -56     
- Misses       1783     1865      +82     
- Partials      475      504      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov