Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify meta provider #1665

Merged
merged 17 commits into from
Aug 15, 2024
Merged

Spotify meta provider #1665

merged 17 commits into from
Aug 15, 2024

Conversation

nukeop
Copy link
Owner

@nukeop nukeop commented Aug 10, 2024

No description provided.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 45 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (234f676) to head (e9bf3d0).
Report is 18 commits behind head on master.

Files Patch % Lines
packages/ui/lib/components/ArtistAlbums/index.tsx 16.00% 14 Missing and 7 partials ⚠️
packages/core/src/plugins/meta/spotify.ts 87.87% 6 Missing and 2 partials ⚠️
packages/app/app/actions/plugins.tsx 14.28% 4 Missing and 2 partials ⚠️
packages/core/src/rest/Spotify.ts 88.88% 3 Missing and 1 partial ⚠️
packages/app/app/actions/search.ts 25.00% 3 Missing ⚠️
packages/app/app/components/ArtistView/index.tsx 71.42% 2 Missing ⚠️
packages/ui/lib/components/AlbumGrid/index.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   63.85%   64.10%   +0.24%     
==========================================
  Files         376      380       +4     
  Lines        8087     8238     +151     
  Branches      746      757      +11     
==========================================
+ Hits         5164     5281     +117     
- Misses       2275     2299      +24     
- Partials      648      658      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nukeop nukeop merged commit 315ad9b into master Aug 15, 2024
18 checks passed
@nukeop nukeop deleted the feature/spotify-meta-provider branch August 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant