Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Transforms from the SVG Logo #1661

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Remove Transforms from the SVG Logo #1661

merged 1 commit into from
Aug 5, 2024

Conversation

manuth
Copy link
Contributor

@manuth manuth commented Aug 5, 2024

For whatever reason, all KDE programs I have tested don't seem to support SVG elements involving both transformations and filters.

Thus, changes made in this PR flatten the transforms by instead directly editing the coordinates of the underlying elements.

Following KDE programs I have tested so far will show only the gradient background but not the white symbol when opening or previewing the file:

  • Dolphin (file preview)
  • Plasma Shell (when set as desktop icon)
  • Koko (KDE image viewer)
  • KolourPaint (KDE paint program)
  • Konqueror (KDE web browser)

This is most likely an error on KDE's side - however, this is quite disturbing when setting the SVG icon as desktop icon.

I think it might be reasonable to "hot fix" the logo for now.

@nukeop
Copy link
Owner

nukeop commented Aug 5, 2024

Awesome, this could solve other problems with icons too. I made it using Inkscape and didn't think twice about the way it's exported.

@nukeop nukeop merged commit e7240bd into nukeop:master Aug 5, 2024
@manuth
Copy link
Contributor Author

manuth commented Aug 5, 2024

Thank you so much for taking care so quickly!

Tried to fix it by exporting different kinds of SVGs from Inkscape, too, but none of them worked.
I managed it to fix it by transferring the SVG statements to an empty file line-by-line 😭 😂

@nukeop
Copy link
Owner

nukeop commented Aug 7, 2024

This fixed the issue on my i3+KDE desktop. Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants