-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Track Matching #1382
[Feature] Track Matching #1382
Conversation
Could you please reset package-lock.json for this PR so that the diff is smaller? |
a170288
to
175d27d
Compare
I'm gonna start writing tests now. There are 2 worrying failures:
I'm gonna see if I can fix these test cases while still preserving your new rules. |
Ok, I added back the title score but weighed it lower, so that it only decides if all else is very similar. Otherwise looks like all of your changes are weight adjustments, so they're covered by existing tests and don't need to be covered again. Would you like to merge this now? |
Codecov ReportBase: 70.71% // Head: 70.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
==========================================
- Coverage 70.71% 70.71% -0.01%
==========================================
Files 360 360
Lines 6588 6590 +2
Branches 456 456
==========================================
+ Hits 4659 4660 +1
- Misses 1551 1553 +2
+ Partials 378 377 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'll test it quick. I have a playlist of varied music I was validating against (it had a few songs that didn't play nicely with title score so I will see if the new weights work) |
I didn't see any major issues with the title score added back at low weight (only a few music videos where it would have previously been the official track). Should I leave in the hacks for preventing undefined tracks? |
Sure, it will stop being a problem when ytdl-core is updated, but it can stay until then. |
Sounds good! Thanks for all the help! |
Improved Youtube heuristics to make playing the correct track more consistent