Skip to content

Commit

Permalink
Merge pull request #1369 from mashazyu/chore/add-favorite-tracks-sorting
Browse files Browse the repository at this point in the history 
Chore: add favorite tracks sorting
  • Loading branch information
@nukeop
nukeop authored Nov 27, 2022
2 parents 2857d93 + 152b242 commit e8fcb68
Show file tree
Hide file tree
Showing 16 changed files with 590 additions and 63 deletions.
34 changes: 32 additions & 2 deletions ...ages/app/app/containers/AlbumViewContainer/__snapshots__/AlbumViewContainer.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,31 +129,52 @@ exports[`Album view container should display an album 1`] = `
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
<span
class="center_aligned"
class="title_with_icon"
data-testid="position-header"
>
<i
aria-hidden="true"
class="hashtag icon"
/>
<i
aria-hidden="true"
class="sort content ascending icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
 
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Title
<span
class="title_with_icon"
>
Title
<i
aria-hidden="true"
class="sort content ascending disabled icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Length
</th>
Expand Down Expand Up @@ -191,10 +212,12 @@ exports[`Album view container should display an album 1`] = `
class=""
data-rbd-draggable-context-id="0"
data-rbd-draggable-id="test track 1 0"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -227,6 +250,7 @@ exports[`Album view container should display an album 1`] = `
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down Expand Up @@ -290,10 +314,12 @@ exports[`Album view container should display an album 1`] = `
class=""
data-rbd-draggable-context-id="0"
data-rbd-draggable-id="test track 2 1"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -326,6 +352,7 @@ exports[`Album view container should display an album 1`] = `
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down Expand Up @@ -389,10 +416,12 @@ exports[`Album view container should display an album 1`] = `
class=""
data-rbd-draggable-context-id="0"
data-rbd-draggable-id="test track 3 2"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -425,6 +454,7 @@ exports[`Album view container should display an album 1`] = `
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down
45 changes: 42 additions & 3 deletions ...ages/app/app/containers/DashboardContainer/__snapshots__/DashboardContainer.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -840,19 +840,28 @@ exports[`Dashboard container should display top tracks after going to top tracks
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
<span
class="center_aligned"
class="title_with_icon"
data-testid="position-header"
>
<i
aria-hidden="true"
class="hashtag icon"
/>
<i
aria-hidden="true"
class="sort content ascending icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
<span
class="center_aligned"
Expand All @@ -866,24 +875,48 @@ exports[`Dashboard container should display top tracks after going to top tracks
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
 
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Title
<span
class="title_with_icon"
>
Title
<i
aria-hidden="true"
class="sort content ascending disabled icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Artist
<span
class="title_with_icon"
>
Artist
<i
aria-hidden="true"
class="sort content ascending disabled icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Length
</th>
Expand Down Expand Up @@ -921,10 +954,12 @@ exports[`Dashboard container should display top tracks after going to top tracks
class=""
data-rbd-draggable-context-id="0"
data-rbd-draggable-id="top track 1 0"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -966,6 +1001,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down Expand Up @@ -1034,10 +1070,12 @@ exports[`Dashboard container should display top tracks after going to top tracks
class=""
data-rbd-draggable-context-id="0"
data-rbd-draggable-id="top track 2 1"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -1079,6 +1117,7 @@ exports[`Dashboard container should display top tracks after going to top tracks
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down
43 changes: 40 additions & 3 deletions ...pp/app/containers/DeezerPlaylistAdapter/__snapshots__/DeezerPlaylistAdapter.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,19 +76,28 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
<span
class="center_aligned"
class="title_with_icon"
data-testid="position-header"
>
<i
aria-hidden="true"
class="hashtag icon"
/>
<i
aria-hidden="true"
class="sort content ascending icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
<span
class="center_aligned"
Expand All @@ -102,20 +111,42 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
 
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Title
<span
class="title_with_icon"
>
Title
<i
aria-hidden="true"
class="sort content ascending disabled icon"
/>
</span>
</th>
<th
colspan="1"
role="columnheader"
style="cursor: pointer;"
title="Toggle SortBy"
>
Artist
<span
class="title_with_icon"
>
Artist
<i
aria-hidden="true"
class="sort content ascending disabled icon"
/>
</span>
</th>
<th
colspan="1"
Expand Down Expand Up @@ -151,10 +182,12 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
class=""
data-rbd-draggable-context-id="1"
data-rbd-draggable-id="track 1 0"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -196,6 +229,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down Expand Up @@ -259,10 +293,12 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
class=""
data-rbd-draggable-context-id="1"
data-rbd-draggable-id="track 2 1"
data-testid="track-table-row"
role="row"
>
<td
class="position_cell narrow"
data-testid="position-cell"
role="cell"
>
<button
Expand Down Expand Up @@ -304,6 +340,7 @@ exports[`Deezer playlist adapter should display a Deezer playlist 1`] = `
</td>
<td
class="title_cell"
data-testid="title-cell"
role="cell"
>
<span
Expand Down
Loading

0 comments on commit e8fcb68

Please sign in to comment.