Merge branch 'hotfix/0.17.6'

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [vNext]
 
+## [0.17.6] / 2019-03-04
+- Fixed `RequirementService` to check for `ParameterAttribute` when injecting values interactively
+
 ## [0.17.5] / 2019-03-03
 - Fixed `GlobDirectories` and `GlobFiles` to not collect items lazily
 
@@ -324,7 +327,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added CLT tasks for Git
 - Fixed background color in console output
 
-[vNext]: https://github.com/nuke-build/common/compare/0.17.5...HEAD
+[vNext]: https://github.com/nuke-build/common/compare/0.17.6...HEAD
+[0.17.6]: https://github.com/nuke-build/common/compare/0.17.5...0.17.6
 [0.17.5]: https://github.com/nuke-build/common/compare/0.17.4...0.17.5
 [0.17.4]: https://github.com/nuke-build/common/compare/0.17.3...0.17.4
 [0.17.3]: https://github.com/nuke-build/common/compare/0.17.2...0.17.3

source/Nuke.Common/Execution/RequirementService.cs

@@ -22,7 +22,7 @@ public static void ValidateRequirements(NukeBuild build)
             {
                 if (requirement is Expression<Func<bool>> boolExpression)
                     ControlFlow.Assert(boolExpression.Compile().Invoke(), $"Target '{target.Name}' requires '{requirement.Body}'.");
-                else if (IsMemberNull(requirement.GetMemberInfo(), build))
+                else if (IsMemberNull(requirement.GetMemberInfo(), build, target))
                     ControlFlow.Fail($"Target '{target.Name}' requires member '{requirement.GetMemberInfo().Name}' to be not null.");
             }
 
@@ -34,8 +34,12 @@ public static void ValidateRequirements(NukeBuild build)
             }
         }
 
-        private static bool IsMemberNull(MemberInfo member, NukeBuild build)
+        private static bool IsMemberNull(MemberInfo member, NukeBuild build, ExecutableTarget target = null)
         {
+            var from = target != null ? $"from target '{target.Name}' " : string.Empty;
+            ControlFlow.Assert(member.HasCustomAttribute<ParameterAttribute>(),
+                $"Member '{member.Name}' is required {from}but not marked with a {nameof(ParameterAttribute)}.");
+
             if (NukeBuild.Host == HostType.Console)
                 InjectValueInteractive(build, member);