Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a blank nue example project for use with 'create' cli #466

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexpricedev
Copy link
Contributor

Summary

This PR adds a new "blank" example nue project to the create CLI as after starting two simple-blog projects and having to delete most of the dirs I wanted a cleaner starting place.

Screenshots

Screenshot 2025-01-27 at 20 22 56

Changes Made

  1. Adds a new blank project in packages/examples/blank/
  2. Adds blank to the push-examples GHA
  3. Adds support for blank in the create CLI js file

Notes

  1. I've not actually be able to test that the CLI part works as the bundle needs to be pushed up first, but I assume all that pipeline works as expected 🤞
  2. Whilst this "blank" template could be emptier I wanted to retain the important file structure elements and some example code as a jumping off point for new and seasoned users

@nobkd
Copy link
Collaborator

nobkd commented Jan 27, 2025

The action code etc. looks fine.

You may want to either add a welcome page or change line 13 in create.js to open / instead of /welcome/ for the blank example. Not completely sure how to handle that, but maybe you have an suggestion. (idea: const object variable that lists project starter names as keys and opened page as value. Is used to check if template exists, and which page to start on. I'm open to more ideas)

In the end, it's up to @tipiirai to decide to add this example (and secrets and storage / pull zone)

@nobkd nobkd requested a review from tipiirai January 27, 2025 21:01
@alexpricedev
Copy link
Contributor Author

alexpricedev commented Jan 28, 2025

Great shout about /welcome. I'll have a look at that!

@alexpricedev
Copy link
Contributor Author

alexpricedev commented Jan 29, 2025

I've added a redirect from /welcome to /.

Doesn't feel like a super clean solution but it was good for me to play with some of the scripting stuff and might be useful for others?

Also up for creating an opening page mapper if thats a better solution. Not sure if we'll be able to tell which template was used though. Maybe on first load? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants