Moves init schema to separate workflow + creates schema manager #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
==========================================
+ Coverage 25.51% 25.59% +0.07%
==========================================
Files 401 409 +8
Lines 46905 47078 +173
==========================================
+ Hits 11970 12048 +78
- Misses 33772 33862 +90
- Partials 1163 1168 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchstat Geomean Results0.72% sec/op, -0.03% B/op, 0.00% allocs/op Benchstat results |
nickzelei
approved these changes
Mar 12, 2025
| siWf := &schemainit_workflow.Workflow{} | ||
| var wfResult schemainit_workflow.SchemaInitResponse | ||
| err := workflow.ExecuteChildWorkflow(workflow.WithChildOptions(ctx, workflow.ChildWorkflowOptions{ | ||
| WorkflowID: workflow_shared.BuildChildWorkflowId(jobRunId, "init-schema", workflow.Now(ctx)), |
There was a problem hiding this comment.
worth adding the destination id into the workflow id so that it is unique. yea we are using the time here but it might still cause dupes if it happens quick enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the schema manager makes it easier to only update mysql to do incremental schema updates and let sqlserver and postgres stay the same