Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mysql create indexes and adds complex mysql integration test #3345

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alishakawaguchi
Copy link
Contributor

@alishakawaguchi alishakawaguchi commented Mar 11, 2025

didn't support different index types and the query for composite indexes was only returning one column in some cases

@alishakawaguchi alishakawaguchi added bug Something isn't working Devex Created by Linear-GitHub Sync labels Mar 11, 2025
@alishakawaguchi alishakawaguchi self-assigned this Mar 11, 2025
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 5:28pm

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 24.62%. Comparing base (dd7dd4e) to head (c483764).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/pkg/sqlmanager/mysql/mysql-manager.go 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
- Coverage   24.65%   24.62%   -0.03%     
==========================================
  Files         395      395              
  Lines       45872    45938      +66     
==========================================
+ Hits        11310    11313       +3     
- Misses      33441    33505      +64     
+ Partials     1121     1120       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Mar 11, 2025

Benchstat Geomean Results

1.47% sec/op, -0.01% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │       sec/op       │    sec/op     vs base               │
CleanPostgresType-4                         42.63n ± 4%   42.32n ± 98%        ~ (p=0.121 n=6)
Runner_Single-4                             7.713µ ± 5%   7.852µ ±  2%        ~ (p=0.310 n=6)
GenerateBool-4                              11.45n ± 1%   11.52n ±  1%        ~ (p=0.790 n=6)
GenerateBusinessName-4                      285.4n ± 0%   321.8n ±  4%  +12.74% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.49n ±  2%        ~ (p=0.258 n=6)
GenerateCategorical-4                       104.1n ± 2%   104.7n ±  2%        ~ (p=0.087 n=6)
GenerateCity-4                              173.7n ± 0%   175.3n ±  1%   +0.95% (p=0.002 n=6)
GenerateCountry-4                           105.2n ± 1%   107.8n ±  1%   +2.47% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.352µ ±  0%   +0.45% (p=0.017 n=6)
GenerateFirstName-4                         203.9n ± 0%   203.8n ±  1%        ~ (p=0.894 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.89n ±  1%   +0.52% (p=0.039 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.455µ ±  1%        ~ (p=0.065 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.433µ ±  4%  +17.27% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%   41.94n ±  1%   +1.26% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%   28.46n ±  0%        ~ (p=1.000 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.78n ±  1%        ~ (p=0.095 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   175.5n ±  0%        ~ (p=0.368 n=6)
GenerateIpAddress-4                         569.3n ± 0%   523.6n ±  1%   -8.01% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   196.3n ±  3%   +4.72% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   992.1n ±  2%        ~ (p=0.132 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.027µ ±  0%   +0.98% (p=0.002 n=6)
GenerateSSN-4                               305.8n ± 1%   305.8n ±  2%        ~ (p=0.976 n=6)
GenerateState-4                             105.2n ± 2%   106.3n ±  0%        ~ (p=0.058 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   206.5n ±  0%   +1.27% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   180.8n ±  0%   +0.81% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.48n ±  3%        ~ (p=0.065 n=6)
GenerateUsername-4                          351.5n ± 0%   361.9n ±  6%   +2.99% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.3n ±  1%        ~ (p=0.777 n=6)
GenerateUUID-4                              734.0n ± 0%   751.4n ±  0%   +2.38% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   107.0n ±  0%   +1.76% (p=0.009 n=6)
TransformCharacterScramble-4                171.8n ± 1%   171.9n ±  1%        ~ (p=0.732 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   180.2n ±  0%        ~ (p=0.976 n=6)
TransformEmail-4                            1.798µ ± 2%   1.811µ ±  1%        ~ (p=0.290 n=6)
TransformFirstName-4                        233.9n ± 0%   239.1n ±  1%   +2.20% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%   112.7n ±  1%        ~ (p=0.457 n=6)
TransformFullName-4                         1.235µ ± 2%   1.324µ ±  4%   +7.21% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%   33.75n ±  0%        ~ (p=1.000 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   58.02n ±  0%        ~ (p=0.058 n=6)
TransformLastName-4                         191.6n ± 0%   194.1n ±  1%   +1.30% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%   1.031µ ±  1%   +0.78% (p=0.006 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   209.6n ±  0%   -0.66% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%   36.94n ±  0%   +1.09% (p=0.002 n=6)
geomean                                     194.0n        196.9n         +1.47%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.302Ki ± 1%       ~ (p=0.788 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 3%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Devex Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant