Postgres support for partitioned tables #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
alishakawaguchi
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 24.65% 24.62% -0.03%
==========================================
Files 395 395
Lines 45872 45919 +47
==========================================
- Hits 11310 11308 -2
- Misses 33441 33489 +48
- Partials 1121 1122 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchstat Geomean Results0.26% sec/op, -0.02% B/op, 0.00% allocs/op Benchstat results |
nickzelei
approved these changes
Mar 10, 2025
| @@ -708,7 +760,7 @@ BEGIN | |||
| SELECT 1 | |||
| FROM pg_class c | |||
| JOIN pg_namespace n ON n.oid = c.relnamespace | |||
| WHERE c.relkind = 'i' | |||
| WHERE c.relkind in ('i', 'I') | |||
There was a problem hiding this comment.
what does the capital I entail?
There was a problem hiding this comment.
I = partitioned index
There was a problem hiding this comment.
thanks postgres that is super clear.
| @@ -317,7 +317,7 @@ func (p *PostgresTestContainer) DropSchemas(ctx context.Context, schemas []strin | |||
| } | |||
|
|
|||
| func (p *PostgresTestContainer) GetTableRowCount(ctx context.Context, schema, table string) (int, error) { | |||
| rows := p.DB.QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*) FROM ONLY %q.%q;", schema, table)) | |||
| rows := p.DB.QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*) FROM %q.%q;", schema, table)) | |||
There was a problem hiding this comment.
interesting, what was the ONLY doing that broke this?
There was a problem hiding this comment.
I accidentally left that in when I was trying to get inherited tables to work. It was breaking the partitioned tables counts since ONLY ignores any rows that exist in the child tables
| Count: destOpts.BatchCount, | ||
| Period: destOpts.BatchPeriod, | ||
| Count: destOpts.BatchCount, | ||
| Processors: []*neosync_benthos.BatchProcessor{sqlProcessor}, |
There was a problem hiding this comment.
maybe weird diff, but were we basically building the processors but never actually doing anything with them? And now we are?
There was a problem hiding this comment.
we were only using the processors on insert configs. Now we use the processors on the insert and update configs
nickzelei
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed neosync type bug when updating table
Fixed postgres get extensions query returning all schema specific extensions