Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes account hooks to not halt on first failure #3328

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

nickzelei
Copy link
Member

for multiple account hooks this would be bad if one of them is not working correctly.

This way each one gets to run to its fullest and we return all of the hook failures as a single joined error message.

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 11:53pm

@nickzelei nickzelei added the bug Something isn't working label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.63%. Comparing base (a44d6b0) to head (021a7a1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
+ Coverage   24.62%   24.63%   +0.01%     
==========================================
  Files         394      394              
  Lines       46002    46006       +4     
==========================================
+ Hits        11326    11335       +9     
+ Misses      33547    33545       -2     
+ Partials     1129     1126       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Mar 6, 2025

Benchstat Geomean Results

0.33% sec/op, -0.02% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │       sec/op       │   sec/op     vs base               │
CleanPostgresType-4                         42.63n ± 4%   41.74n ± 2%   -2.08% (p=0.004 n=6)
Runner_Single-4                             7.713µ ± 5%   7.641µ ± 1%   -0.93% (p=0.026 n=6)
GenerateBool-4                              11.45n ± 1%   11.34n ± 3%        ~ (p=0.290 n=6)
GenerateBusinessName-4                      285.4n ± 0%   293.5n ± 3%   +2.84% (p=0.015 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.48n ± 1%        ~ (p=0.394 n=6)
GenerateCategorical-4                       104.1n ± 2%   102.5n ± 0%   -1.59% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%   175.8n ± 2%   +1.18% (p=0.002 n=6)
GenerateCountry-4                           105.2n ± 1%   106.0n ± 1%        ~ (p=0.240 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.334µ ± 0%   -0.93% (p=0.002 n=6)
GenerateFirstName-4                         203.9n ± 0%   199.6n ± 0%   -2.11% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.68n ± 1%        ~ (p=0.589 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.445µ ± 0%        ~ (p=0.119 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.238µ ± 1%   +1.35% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%   46.85n ± 0%  +13.08% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%   27.88n ± 1%   -1.87% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.60n ± 1%        ~ (p=0.589 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   177.1n ± 1%   +0.71% (p=0.011 n=6)
GenerateIpAddress-4                         569.3n ± 0%   577.5n ± 0%   +1.45% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   190.1n ± 1%   +1.39% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   983.1n ± 0%        ~ (p=0.240 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.020µ ± 0%   +0.30% (p=0.037 n=6)
GenerateSSN-4                               305.8n ± 1%   303.5n ± 0%   -0.74% (p=0.002 n=6)
GenerateState-4                             105.2n ± 2%   105.3n ± 0%        ~ (p=0.626 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   205.6n ± 6%   +0.81% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   171.4n ± 1%   -4.41% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.42n ± 0%        ~ (p=0.169 n=6)
GenerateUsername-4                          351.5n ± 0%   355.2n ± 0%   +1.07% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.2n ± 0%        ~ (p=0.699 n=6)
GenerateUUID-4                              734.0n ± 0%   741.6n ± 1%   +1.04% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   106.2n ± 2%   +0.95% (p=0.041 n=6)
TransformCharacterScramble-4                171.8n ± 1%   172.4n ± 1%   +0.41% (p=0.028 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   180.0n ± 1%        ~ (p=0.461 n=6)
TransformEmail-4                            1.798µ ± 2%   1.790µ ± 0%   -0.44% (p=0.004 n=6)
TransformFirstName-4                        233.9n ± 0%   235.3n ± 0%   +0.60% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%   115.2n ± 0%   +3.92% (p=0.030 n=6)
TransformFullName-4                         1.235µ ± 2%   1.248µ ± 1%   +1.13% (p=0.035 n=6)
TransformInt64-4                            33.74n ± 1%   33.16n ± 0%   -1.73% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   57.98n ± 1%        ~ (p=0.071 n=6)
TransformLastName-4                         191.6n ± 0%   192.1n ± 1%        ~ (p=0.221 n=6)
TransformString-4                           1.022µ ± 0%   1.022µ ± 0%        ~ (p=0.509 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   205.1n ± 1%   -2.77% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%   36.73n ± 0%   +0.52% (p=0.037 n=6)
geomean                                     194.0n        194.6n        +0.33%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.292Ki ± 1%       ~ (p=0.223 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 0%       ~ (p=0.455 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei merged commit 8b534e3 into main Mar 6, 2025
15 checks passed
@nickzelei nickzelei deleted the nick/change-account-hooks-execution branch March 6, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants