Runconfigs V2 - adds stability, removes complexity #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Benchstat Geomean Results0.41% sec/op, -0.08% B/op, 0.00% allocs/op Benchstat results |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
==========================================
+ Coverage 24.61% 24.66% +0.04%
==========================================
Files 394 395 +1
Lines 45997 45867 -130
==========================================
- Hits 11323 11311 -12
+ Misses 33544 33435 -109
+ Partials 1130 1121 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alishakawaguchi
changed the title
nickzelei
reviewed
Mar 5, 2025
| qb := NewSelectQueryBuilder("public", driver, subsetByForeignKeyConstraints, pageLimit) | ||
| querymap := map[string]*sqlmanager_shared.SelectQuery{} | ||
| for _, cfg := range runConfigs { | ||
| query, _, pageQuery, isNotForeignKeySafe, err := qb.BuildQuery(cfg) |
There was a problem hiding this comment.
confused as to where the isNotForeignKeySafe is defined.
There was a problem hiding this comment.
I should probably rename that. It really just tells me when a query is a subset query and needs to turn skip fk violations when inserting or updating. It gets determined when building the select query.
nickzelei
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies run config and query builder logic.
For circular dependencies and subsets removes complicated logic around optimal path. Now it determines update configs based on tables nullable foreign keys. A separate update config is created for each nullable foreign key on the table.
Moves subset joining logic into run config builder because we create update configs for subset tables now. It computes the shortest path from every child table to all parent subsets. This reduces unnecessary and complicated joins