Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move configuration to PHP #65

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Fix: Move configuration to PHP #65

merged 1 commit into from
Jul 4, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jul 4, 2020

There was an error in the service definition.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #65 into main will increase coverage by 0.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #65      +/-   ##
============================================
+ Coverage     93.50%   94.44%   +0.93%     
  Complexity       52       52              
============================================
  Files             9       12       +3     
  Lines           154      180      +26     
============================================
+ Hits            144      170      +26     
  Misses           10       10              
Impacted Files Coverage Δ Complexity Δ
src/DependencyInjection/NucleosMatomoExtension.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/Resources/config/block.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/services.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/twig.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5d8b9...e8605a1. Read the comment docs.

@kodiakhq kodiakhq bot merged commit b5dcc51 into main Jul 4, 2020
@core23 core23 deleted the php-files branch July 4, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant