Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger Host Alert #1

Closed
wants to merge 14 commits into from
Closed

Trigger Host Alert #1

wants to merge 14 commits into from

Conversation

lorenzobrunetti
Copy link
Contributor

Trigger Host Details is now under the alert section and appear only for
remote hosts

@lorenzobrunetti
Trigger Host Alert
2ad4ece 
Trigger Host Details is now under the alert section and appear only for
remote hosts
@lorenzobrunetti
Added flow_dump
93c73c9 
Added flow_dump option in Network_interface class to disable flow dump
on a specific interface
@lucaderi
Copy link
Member

lucaderi commented May 3, 2015

Some comments

  1. The code you sent me isn't in sync with the repository: please update your code first.
  2. The alerts should be generated only by local hosts (not the other way round).
  3. When you define NetworkInterface::getdumpFlowPreference() please capitalise names (i.e. NetworkInterface::getDumpFlowPreference) and make it mode meaningful. As this method returns a boolean your should not use getXXX as it expects a value back
  4. For methods such as those you defined, please make them inline.
    Please fix the above issues and try again submitting your contribution

@lorenzobrunetti
Merge remote-tracking branch 'ntop/dev' into dev
07b3790
@lorenzobrunetti
Make Flow_dump Method inline
c8c055f 
Flow_dump is now accessible through inline method in Network Interface
header class
@lorenzobrunetti
Added flow_dump control in InterfaceView
f8132f5 
Added function in InterfaceView to get flow_dump policy, correct
flow.cpp with the new method name.
Created new method in lua.cpp to get flow_dump variable
@lorenzobrunetti
Merge branch 'ntop/dev' into dev
7ba7d55
@lorenzobrunetti
Flow Dump
b95e670 
Now you can disable flow dump for a specific interface
@lorenzobrunetti
merge from ntop/dev
b2894df
@lorenzobrunetti
Merge branch 'ntop/dev' into dev
c1c2a5f 
Conflicts:
	.gitignore
	scripts/lua/host_details.lua
@lorenzobrunetti
ReUp host_details
e8b5336 
ReUp host_detils.lua
@lorenzobrunetti
Merge remote-tracking branch 'ntop/dev' into dev
49239d1
@lorenzobrunetti
merge 'dev' to 'dev'
db91f58
@lorenzobrunetti
Merge remote-tracking branch 'ntop/dev' into dev
ebce139
@lorenzobrunetti
Removed Alert Logo For local hosts
39cfbcb 
The alert logo is now hidden for local hosts
This was referenced May 9, 2015
Closed
Closed
@ariava ariava closed this May 11, 2015
@paoloB132 paoloB132 mentioned this pull request Jun 1, 2015
Closed
@DelltaPeak DelltaPeak mentioned this pull request Jul 29, 2015
Closed
@paoloB132 paoloB132 mentioned this pull request Aug 31, 2015
Closed
@JuergenWeber JuergenWeber mentioned this pull request Sep 11, 2015
Closed
@vidgizmo vidgizmo mentioned this pull request Sep 17, 2015
Closed
@ayera-hstack ayera-hstack mentioned this pull request Sep 23, 2015
Closed
@mineumann mineumann mentioned this pull request Oct 15, 2015
Closed
@nazhu nazhu mentioned this pull request Oct 22, 2015
Closed
@ffkammer ffkammer mentioned this pull request Dec 19, 2015
Closed
@hvdbrand hvdbrand mentioned this pull request Dec 25, 2015
Closed
@shadrack222 shadrack222 mentioned this pull request Jan 18, 2016
Closed
@sthen sthen mentioned this pull request Feb 15, 2016
Closed
@AngeloColucci AngeloColucci mentioned this pull request Mar 25, 2021
Closed
@lucaderi lucaderi mentioned this pull request Apr 9, 2021
Closed
@cardigliano cardigliano mentioned this pull request Apr 23, 2021
Closed
@kfra71 kfra71 mentioned this pull request Apr 26, 2021
Closed
@aaali22 aaali22 mentioned this pull request Jun 5, 2021
Closed
@nobless nobless mentioned this pull request Aug 14, 2021
Closed
@lucaderi lucaderi mentioned this pull request Oct 25, 2021
Closed
@lucaderi lucaderi mentioned this pull request Nov 4, 2021
Closed
@lucaderi lucaderi mentioned this pull request Nov 11, 2021
Closed
@wwazzi wwazzi mentioned this pull request Jan 3, 2022
Closed
@notyourcommy notyourcommy mentioned this pull request Jan 30, 2022
Closed
@MatteoBiscosi MatteoBiscosi mentioned this pull request Apr 29, 2022
Closed
cardigliano pushed a commit that referenced this pull request May 13, 2022
@JudyyHopps
Merge pull request #1 from JudyyHopps/JudyyHopps-token
5c7fc42 
add token based auth
@deanfourie1 deanfourie1 mentioned this pull request Jun 21, 2022
Closed
This was referenced Jan 14, 2023
Closed
Closed
Closed
@atemix atemix mentioned this pull request Feb 3, 2023
Closed
This was referenced Feb 17, 2023
Closed
Closed
j0ji-k pushed a commit to j0ji-k/ntopng that referenced this pull request May 2, 2023
@tomothy83
Merge pull request ntop#1 from j0ji-k/restore-recipient-api
98ecb7a 
Restore host pools in endpoints import.
@notyourcommy notyourcommy mentioned this pull request Aug 6, 2023
Closed
@cardigliano cardigliano mentioned this pull request Jan 16, 2024
Closed
@lucaderi lucaderi mentioned this pull request May 2, 2024
Closed
cardigliano pushed a commit that referenced this pull request May 24, 2024
@mzac
Merge pull request #1 from mzac/mzac-patch-1
1edfccd 
Update ntop_defines.h
@atemix atemix mentioned this pull request Jun 5, 2024
Closed
@612wong 612wong mentioned this pull request Aug 21, 2024
Closed
@Achronium Achronium mentioned this pull request Oct 22, 2024
Closed
@xaqpuyrthnbg xaqpuyrthnbg mentioned this pull request Dec 15, 2024
Closed
@ae4ml ae4ml mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzobrunetti @lucaderi @ariava