config: extend unit tests

ntop · Dec 11, 2023 · 8b08d13 · 8b08d13
1 parent 4d9ec7f
commit 8b08d13
Show file tree

Hide file tree

Showing 6 changed files with 101 additions and 4 deletions.
diff --git a/example/ndpiReader.c b/example/ndpiReader.c
@@ -1006,7 +1006,7 @@ static void parseOptions(int argc, char **argv) {
 
     case 'd':
       enable_protocol_guess = 0;
-      if(__add_cfg(NULL, "guess_on_giveup", "0") == 1) {
+      if(__add_cfg(NULL, ndpi_strdup("guess_on_giveup"), ndpi_strdup("0")) == 1) {
         printf("Invalid parameter [%s] [num:%d/%d]\n", optarg, num_cfgs, MAX_NUM_CFGS);
         exit(1);
       }

diff --git a/python/ndpi/ndpi.py b/python/ndpi/ndpi.py
@@ -57,10 +57,9 @@ def process_packet(self, flow, packet, packet_time_ms, input_info):
                              app_protocol=p.app_protocol,
                              category=p.category)
 
-    def giveup(self, flow, enable_guess=True):
+    def giveup(self, flow):
         p = lib.ndpi_detection_giveup(self._detection_module,
                                       flow.C,
-                                      enable_guess,
                                       ffi.new("uint8_t*", 0))
         return ndpi_protocol(C=p,
                              master_protocol=p.master_protocol,

diff --git a/python/ndpi/ndpi_build.py b/python/ndpi/ndpi_build.py
@@ -60,7 +60,6 @@
                                             const struct ndpi_flow_input_info *input_info);
 ndpi_protocol ndpi_detection_giveup(struct ndpi_detection_module_struct *ndpi_struct,
                                     struct ndpi_flow_struct *flow,
-                                    u_int8_t enable_guess,
                                     u_int8_t *protocol_was_guessed);
 void ndpi_py_setup_detection_module(struct ndpi_detection_module_struct *mod);
 struct ndpi_flow_struct * ndpi_py_initialize_flow(void);

diff --git a/tests/cfgs/guessing_disable/config.txt b/tests/cfgs/guessing_disable/config.txt
@@ -0,0 +1 @@
+-d
diff --git a/tests/cfgs/guessing_disable/pcap/webex.pcap b/tests/cfgs/guessing_disable/pcap/webex.pcap
@@ -0,0 +1 @@
+../../default/pcap/webex.pcap