Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid corruption when metadata is inconsistent (writePos vs write file size) #31

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

fazalmajid
Copy link
Contributor

…ue was not synced on previous shutdown

Example: if nsqd was forcibly killed before it could complete sync of all the diskqueues' metadata files

…a queue was not synced on previous shutdown
@mreiferson mreiferson added the bug label Jul 5, 2021
@mreiferson mreiferson changed the title mitigation for #28 possible data corruption if the metadata for a que… avoid corruption when metadata is inconsistent (writePos vs write file size) Jul 5, 2021
@mreiferson
Copy link
Member

LGTM, thanks!

@mreiferson mreiferson merged commit 84d80dc into nsqio:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants