Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add new tests with main chain #947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evgeniiz321
Copy link
Contributor

Part of #943

{% if ir_public_keys | length > 1 %}
Genesis:
Roles:
NeoFSAlphabet:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? You can always set the ones you want and it's ok to have none by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is based on https://github.com/nspcc-dev/neofs-dev-env/blob/master/services/chain/protocol.privnet1.yml configs, where Genesis part is omitted in case of a single IR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't affect the result in our case, but still that's not the way mainnet/testnet work.

@evgeniiz321 evgeniiz321 force-pushed the ezayats/new-deployment-tests branch from aedee27 to c82bfc5 Compare February 12, 2025 22:45
closes #943

Signed-off-by: Evgeniy Zayats <[email protected]>
@evgeniiz321 evgeniiz321 force-pushed the ezayats/new-deployment-tests branch from c82bfc5 to fc20f20 Compare February 12, 2025 22:52
@evgeniiz321 evgeniiz321 changed the title tests: add new deployment tests with main chain tests: add new tests with main chain Feb 12, 2025
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have closes #943 in your commit message.

gas="200.0",
)

new_inner_ring_node.start(wait_until_ready=True, with_main_chain=True, fschain_autodeploy=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why autodeploy=false here? Does it affect the node in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants