Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix tests to match updated node behavior #774

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

roman-khimov
Copy link
Member

This effectively reverts 603de8d, but current node returns 2048 again.

This effectively reverts 603de8d, but current
node returns 2048 again.

Signed-off-by: Roman Khimov <[email protected]>
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what node issue/PR reversed the behavior? lets mention it in the commit, i cant follow the tracks

@roman-khimov
Copy link
Member Author

That I can't say definitively now. Maybe @carpawell knows.

@roman-khimov
Copy link
Member Author

@roman-khimov
Copy link
Member Author

Maybe triggered by nspcc-dev/neofs-sdk-go@035b5ad?

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Apr 2, 2024

Maybe triggered by nspcc-dev/neofs-sdk-go@035b5ad?

if tests use CLI to sign session tokens (i bet they do), then yes

and maybe @carpawell opened nspcc-dev/neofs-sdk-go#546 while researching this test? There is also nspcc-dev/neofs-node#2731 which may relate one way or another

anyway, if test tries to prepare token with valid (!) format and signed from a party without access rights, then ACCESS_DENIED is an expected status. stranger_wallet in code hints

@roman-khimov roman-khimov merged commit e3d518c into master Apr 3, 2024
1 of 2 checks passed
@roman-khimov roman-khimov deleted the fix-session-test-codes branch April 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants