Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment for current token handling behavior #718 #726

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

MaxGelbakhiani
Copy link

@MaxGelbakhiani MaxGelbakhiani commented Feb 13, 2024

Fixes #718

@evgeniiz321
Copy link
Contributor

when this behavior was introduced? We should use the same version for our new tests (currently we use version: 'tags/v0.39.2', see in .github) and update them as well - dynamic_env_pytest_tests/tests/session_token/test_static_session_token_container.py

@MaxGelbakhiani
Copy link
Author

when this behavior was introduced? We should use the same version for our new tests (currently we use version: 'tags/v0.39.2', see in .github) and update them as well - dynamic_env_pytest_tests/tests/session_token/test_static_session_token_container.py

As stated in #718

We have several session token tests failing after nspcc-dev/neofs-node#2731, the node is fine, tests need to be adjusted.

https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1230-1706624712/index.html#suites/0598eb478b736df2d02c5aa8b49c27f4

@MaxGelbakhiani
Copy link
Author

And current changes should change all the tests to green after node PR 2741 is merged. For now, we'll have 2 yellow tests in this suite.

@roman-khimov
Copy link
Member

Version here can be updated to 0.40.0, we'll deal with test/node sync after we're quit using dev-env.

Fixes #718

Signed-off-by: Maksim Gelbakhiani <[email protected]>
@roman-khimov roman-khimov merged commit e567c71 into master Feb 19, 2024
2 checks passed
@roman-khimov roman-khimov deleted the token_handling branch February 19, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust tests to the new token handling behavior
3 participants