Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache network settings #251

handler: Update NetworkInfo cache on GetNetworkInfo request

309119b
Select commit
Loading
Failed to load commit list.
Merged

Cache network settings #251

handler: Update NetworkInfo cache on GetNetworkInfo request
309119b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2024 in 1s

23.61% (+0.81%) compared to 02e0776

View this Pull Request on Codecov

23.61% (+0.81%) compared to 02e0776

Details

Codecov Report

Attention: Patch coverage is 35.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 23.61%. Comparing base (02e0776) to head (309119b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
handlers/auth.go 0.00% 10 Missing ⚠️
handlers/containers.go 0.00% 9 Missing ⚠️
internal/cache/networkinfo.go 74.07% 6 Missing and 1 partial ⚠️
handlers/util.go 0.00% 4 Missing ⚠️
handlers/network.go 0.00% 2 Missing ⚠️
handlers/objects.go 0.00% 2 Missing ⚠️
handlers/api.go 0.00% 1 Missing ⚠️
handlers/newObjects.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   22.79%   23.61%   +0.81%     
==========================================
  Files          18       19       +1     
  Lines        3672     4731    +1059     
==========================================
+ Hits          837     1117     +280     
- Misses       2677     3455     +778     
- Partials      158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.