-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2130] adm: Add dump-nns and restore-nns commands #2138
[#2130] adm: Add dump-nns and restore-nns commands #2138
Conversation
Signed-off-by: Denis Kirillov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 30.78% 30.53% -0.25%
==========================================
Files 382 383 +1
Lines 28056 28313 +257
==========================================
+ Hits 8637 8646 +9
- Misses 18687 18935 +248
Partials 732 732 ☔ View full report in Codecov by Sentry. |
Currently, this PR sub-optimal in terms of tx sending (we await txs for every domains, this should be fixed a little bit later). Also there are the following problems/questions:
/cc @alexvanin @fyrchik |
@roman-khimov, @cthulhu-rider, I have checked this PR, TBH, I would redo some things and also it is from an archive repo now. Do not understand the 1st question, we have (and seems like always had Suggest closing this PR, or merging it and continuing immediately with extensions via another PRs. An opened draft for two+ years makes me nervous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This won't merge without update
- Some things need to be fixed, but they will take some time
- I don't believe in dump/restore concept, it's very suspicious to me and I'm not sure we can easily survive this.
- I've never seen this being done in practice and never needed it.
- We'll have Using NeoFS to store blocks and snapshots neo-project/neo#3463 eventually, so chain migration doesn't seem to be valuable at all.
- If needed, the code won't go away and we can return to it.
if isAvailable { | ||
soa := domain.SOA | ||
emit.AppCall(bw.BinWriter, ch, "register", callflag.All, | ||
soa.Name, wCtx.ConsensusAcc.Contract.ScriptHash(), soa.Email, soa.Refresh, soa.Retry, soa.Expire, soa.TTL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's broken here. Domains have owners and we're not keeping them.
close #2130