-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm,dao: return storage iterator from DAO in Storage.Find interop #992
Conversation
Linter is unhappy, because we return unexported type. But it is intended to be opaque. Maybe we should just return an interop item. |
Or maybe we can move |
Codecov Report
@@ Coverage Diff @@
## master-2.x #992 +/- ##
==============================================
- Coverage 67.97% 67.85% -0.13%
==============================================
Files 145 146 +1
Lines 14320 14359 +39
==============================================
+ Hits 9734 9743 +9
- Misses 4126 4155 +29
- Partials 460 461 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg/vm/kek
?
Confirming that it actually fixes #977 too:
Quick application log dump:
|
Reproduce behavior of the reference realization: - if item was Put in cache after it was encountered during Storage.Find, it must appear twice - checking if item is in cache must be performed in real-time during `Iterator.Next()`
All storage items can still be retrived via zero-length prefix.
There is nothing wrong with iterators being implemented in other parts of code (e.g. Storage.Find). In this case type assertions can prevent bugs at compile-time.
Fix #988 .
Reproduce behavior of the reference realization:
Storage.Find, it must appear twice
during
Iterator.Next()
Need too retest #822 .