Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: restrict max invocation stack size #461

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Oct 29, 2019

There should be a limit on invocation stack size. This PR implements it.

See also #373 .

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #461 into master will increase coverage by 0.08%.
The diff coverage is 54.54%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #461      +/-   ##
========================================
+ Coverage   49.92%    50%   +0.08%     
========================================
  Files         103    103              
  Lines        7962   7971       +9     
========================================
+ Hits         3975   3986      +11     
+ Misses       3674   3672       -2     
  Partials      313    313
Impacted Files Coverage Δ
pkg/vm/vm.go 62.45% <54.54%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea7568...c7f0b7b. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.61.0 milestone Oct 29, 2019
pkg/vm/vm.go Outdated Show resolved Hide resolved
pkg/vm/vm_test.go Outdated Show resolved Hide resolved
pkg/vm/vm_test.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit 9a86b2d into master Oct 29, 2019
@roman-khimov roman-khimov deleted the feature/stack_limits branch October 29, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants