Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TX relaying fixes #448

Merged
merged 5 commits into from
Oct 24, 2019
Merged

TX relaying fixes #448

merged 5 commits into from
Oct 24, 2019

Conversation

roman-khimov
Copy link
Member

Problem

Transaction relaying (RPC to NEO) didn't really work

Solution

Added missing functionality, fixed some bugs, including #446.

@roman-khimov
transaction: fix invocation TX consistency in NewInvocationTX()
8d0ed92 
NewInvocationTX() returned a version number one transaction that actually
failed to pass that version down to the invocation data which lead to
serialization/deserialization inconsistency.
@roman-khimov roman-khimov added this to the v0.60.0 milestone Oct 24, 2019
@roman-khimov roman-khimov requested a review from volekerb October 24, 2019 09:34
golangcibot
golangcibot reviewed Oct 24, 2019
View reviewed changes
pkg/network/server.go Outdated Show resolved Hide resolved
pkg/network/server.go Outdated Show resolved Hide resolved
volekerb
volekerb reviewed Oct 24, 2019
View reviewed changes
pkg/network/server.go Outdated Show resolved Hide resolved
@roman-khimov
network: implement getdata message handling in server
257ba1c 
To properly implement relaying we need to answer these requests from other
nodes.
@roman-khimov
core: fix missing unlock in MemPool TryAdd()
184d8a0 
Fixes deadlock on subsequent MemPool operations.
@roman-khimov
core: remove transactions from MemPool when they're stored in block
45cac07 
Extend MemPool with Remove() and use it. Fixes #446.
@roman-khimov
network: move inventory semantic check into common code
9ff55ac 
As per @volekerb suggestion.
@codecov
Copy link

codecov bot commented Oct 24, 2019 •
edited
Loading

Codecov Report

Merging #448 into master will increase coverage by 0.47%.
The diff coverage is 39.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #448      +/-   ##
=========================================
+ Coverage   48.22%   48.7%   +0.47%     
=========================================
  Files         103     103              
  Lines        7861    7909      +48     
=========================================
+ Hits         3791    3852      +61     
+ Misses       3764    3748      -16     
- Partials      306     309       +3
Impacted Files Coverage Δ
pkg/network/server.go 15.51% <0%> (-1.54%) ⬇️
pkg/core/blockchain.go 36.31% <100%> (+0.18%) ⬆️
pkg/core/transaction/invocation.go 90.9% <100%> (+52.81%) ⬆️
pkg/core/mem_pool.go 45.83% <69.56%> (+30.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcf092...9ff55ac. Read the comment docs.

@roman-khimov roman-khimov requested a review from volekerb October 24, 2019 10:16
@volekerb volekerb merged commit 2e99d65 into master Oct 24, 2019
@volekerb volekerb deleted the tx-processing-fixes branch October 24, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@volekerb volekerb volekerb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.60.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roman-khimov @volekerb @golangcibot