Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcbinding: expand struct generator with ToSCParameter #3804

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

roman-khimov
Copy link
Member

Follow-up to 00e22b9, while stackitem.Convertible is good for vm/emit we still need smartcontract.Convertible for invokers.

Follow-up to 00e22b9, while
stackitem.Convertible is good for vm/emit we still need
smartcontract.Convertible for invokers.

Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov roman-khimov added rpc RPC server and client enhancement Improving existing functionality labels Feb 4, 2025
@roman-khimov roman-khimov added this to the v0.108.0 milestone Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 76.56250% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (50cb213) to head (e70b106).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
pkg/smartcontract/rpcbinding/binding.go 76.56% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3804      +/-   ##
==========================================
- Coverage   83.09%   83.08%   -0.01%     
==========================================
  Files         336      336              
  Lines       47090    47154      +64     
==========================================
+ Hits        39128    39179      +51     
- Misses       6359     6374      +15     
+ Partials     1603     1601       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 3fa02d0 into master Feb 4, 2025
33 of 34 checks passed
@roman-khimov roman-khimov deleted the toscparameter branch February 4, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants